dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Feb 2023
9:49 am

Michael Garthwaite

Merge branch 'staging' into DEN-14589-DIAL-221-DIAL-224

Options
9:43 am

Michael Garthwaite

12:09 am

Behrouz NematiPour

It is very disappointing, after years of commenting to fix this error-prone index based, it is still being used and had not been fixed !!!

It is very disappointing, after years of commenting to fix this error-prone index based, it is still being used and had not been fixed !!!

Tuesday 31 Jan 2023
4:31 pm

Dara Navaei

DEN-14604 updated the scripts

Options
    • -1
    • +2
    /dialin/common/dg_defs.py
    • -2
    • +2
    /tests/dg_nvm_scripts.py
    • -77
    • +36
    /tests/dg_tests.py
9:40 am

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -2
    • +2
    /tools/Code_Report.csv
9:38 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /dialin/common/hd_defs.py
    • -2
    • +2
    /dialin/dg/valves.py
    • -2
    • +2
    /dialin/hd/air_trap.py
    • -2
    • +2
    /dialin/hd/alarms.py
    • -1
    • +1
    /dialin/hd/syringe_pump.py
9:37 am

Michael Garthwaite

Merge branch 'DEN-14589-DIAL-221-DIAL-224' into staging

Options
9:36 am

Michael Garthwaite

Merge branch 'staging' into DEN-14589-DIAL-221-DIAL-224

Options
9:36 am

Michael Garthwaite

8:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:50 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

8:48 am

Michael Garthwaite

DEN-14589: code review comments

Options
    • -1
    • +1
    /dialin/dg/valves.py
8:48 am

Sean Nash

Ok, not sure how this got into staging already. Will have to add it back later. RESOLVED in CODE WALKTHROUGH.

Ok, not sure how this got into staging already. Will have to add it back later.
RESOLVED in CODE WALKTHROUGH.

8:47 am

Sean Nash

It does not look aligned with firmware. firmware has: fill, inlet, reserved, ... you now have fill, reserved, drain, ...

It does not look aligned with firmware.
firmware has: fill, inlet, reserved, ...
you now have fill, reserved, drain, ...

Monday 30 Jan 2023
5:35 pm

Dara Navaei

The reserved space belongs to the former reservoir drain valve that was broken into VRD1 and VRD2.

The reserved space belongs to the former reservoir drain valve that was broken into VRD1 and VRD2.

1:34 pm

Michael Garthwaite

This is currently in sync with the VALVES_T struct in the DG firmware. /// Enumeration of valves. typedef enum Valves VRF = 0, ///< Valve Reservoir Fill VRI, ///< Valve Reservoir Inlet RSRVD_SPAC...

This is currently in sync with the VALVES_T struct in the DG firmware.

/// Enumeration of valves.
typedef enum Valves

VRF = 0, ///< Valve Reservoir Fill
VRI, ///< Valve Reservoir Inlet
RSRVD_SPACE, ///< This space has been reserved
VRO, ///< Valve Reservoir Outlet
VPO, ///< Valve Pressure Outlet
VBF, ///< Valve Bypass Filter
VRC, ///< Valve Recirculate
VDR, ///< Valve Drain
VPI, ///< Valve Pressure Inlet
VSP, ///< Valve Sampling Port
VRD1, ///< Valve Reservoir 1 Drain
VRD2, ///< Valve Reservoir 2 Drain
VPD, ///< Valve Production Drain
NUM_OF_VALVES ///< Number of valves
VALVES_T;


Dara Navaei may be able to clarify as to why

1:30 pm

Michael Garthwaite

They are currently out of sync with latest staging builds. Kendrick is currently failing his testing using staging builds if he uses enum 18 to get the HD_EVENT_SUB_STATE_CHANGE that was done in ht...

They are currently out of sync with latest staging builds. Kendrick is currently failing his testing using staging builds if he uses enum 18 to get the HD_EVENT_SUB_STATE_CHANGE that was done in http://devapps.diality.us:8060/cru/HD-DEN-14328-1#details

How do you wish to resolve this?

1:16 pm

Sean Nash

What happened to reservoir inlet valve?

What happened to reservoir inlet valve?

1:13 pm

Sean Nash

I had added button and safety line in another branch. Why removing?

I had added button and safety line in another branch. Why removing?

11:24 am

Michael Garthwaite

11:22 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /dialin/protocols/CAN.py
11:20 am

Michael Garthwaite

Merge branch 'DEN-14415-dialin-hd-events-returns-empty' into staging

Options
11:20 am

Michael Garthwaite

10:25 am

Dara Navaei

9:39 am

Dara Navaei

DEN-14604 updated the scripts to include the Nelson support modes

Options
    • -0
    • +1
    /dialin/common/msg_ids.py
    • -1
    • +6
    /dialin/dg/chemical_disinfect.py
    • -2
    • +43
    /dialin/dg/heat_disinfect.py
    • -1
    • +1
    /dialin/dg/heaters.py
    • -10
    • +15
    /tests/dg_tests.py
Friday 27 Jan 2023
8:16 am

Sean Nash

DEN-14549: Added preload state to syringe pump enum.

Options
    • -5
    • +6
    /dialin/common/hd_defs.py
Thursday 26 Jan 2023
7:01 pm

Dara Navaei

DIALIN-DEN-14415_Dialin HD Events Returns Empty
DIALIN-DEN-14415_Dialin HD Events Returns Empty
5:20 pm

Dara Navaei

Bamboo Commit: generated the code change report

Options
    • -2
    • +0
    /tools/Code_Report.csv
5:18 pm

Michael Garthwaite

Merge branch 'DEN-14415-dialin-hd-events-returns-empty' into develop

Options
5:18 pm

Michael Garthwaite

Merge branch 'DEN-14589-DIAL-221-DIAL-224' into develop

Options
    • -8
    • +6
    /dialin/common/hd_defs.py