Activity dialin/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	21
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Tuesday 16 May 2023

4:34 pm

Dara Navaei

More
7daf8b3
changed 1 file
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 119 more DIALIN-DEN-15274-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

4:32 pm

Michael Garthwaite

More
DIALIN-DEN-15196-3
Closed

4:29 pm

Michael Garthwaite

More
8e9b10b
changed 0 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 119 more

Merge branch 'DEN-15196-DIAL-253' into staging

4:28 pm

Michael Garthwaite

More
01875d0
changed 0 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 120 more

Merge branch 'staging' into DEN-15196-DIAL-253

4:28 pm

Dara Navaei

More
5c6420d
changed 1 file
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 119 more

Bamboo Commit: generated the code change report

- -2
- +9
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

4:27 pm

Dara Navaei

More
2e20a6d
changed 4 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 120 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -2
- +2
/dialin/common/hd_defs.py
- History
- Source
- Diff
/dialin/common/hd_defs.py
- -1
- +1
/dialin/dg/events.py
- History
- Source
- Diff
/dialin/dg/events.py
- -1
- +1
/dialin/hd/hd_events.py
- History
- Source
- Diff
/dialin/hd/hd_events.py

4:25 pm

Michael Garthwaite

More
813a29c
changed 1 file
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 120 more

Merge branch 'DEN-15196-DIAL-251' into staging

- -1
- +2
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py

4:25 pm

Michael Garthwaite

More
DIALIN-DEN-15196-1
Closed

4:24 pm

Michael Garthwaite

Correct

Correct

4:24 pm

Dara Navaei

More
0188c0a
changed 6 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 120 more

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -2
- +2
/dialin/dg/chemical_disinfect.py
- History
- Source
- Diff
/dialin/dg/chemical_disinfect.py
- -2
- +2
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py
- -2
- +2
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py
- -1
- +1
/dialin/protocols/CAN.py
- History
- Source
- Diff
/dialin/protocols/CAN.py
- -2
- +2
/dialin/utils/base.py
- History
- Source
- Diff
/dialin/utils/base.py

4:23 pm

Sean Nash

More
DIALIN-DEN-15196-1
finished reviewing

4:22 pm

Sean Nash

More
Re: DIALIN-DEN-15196-1
replied to jishii (deleted user)

I think I see how it works - thanks for clarifying. In your example, '23' is event id for event status (the new state msg), right? RESOLVED.

I think I see how it works - thanks for clarifying. In your example, '23' is event id for event status (the new state msg), right?
RESOLVED.

4:14 pm

jishii (deleted user)

I'll defer to John he is the one implementing the test code changes.

I'll defer to John he is the one implementing the test code changes.

4:12 pm

Michael Garthwaite

More
cf58be2
changed 0 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 120 more

Merge branch 'DEN-15196-DIAL-250' into staging

4:12 pm

Michael Garthwaite

More
DIALIN-DEN-15196-2
Closed

4:11 pm

Michael Garthwaite

Can you clarify? Events are organized by event id and by time. Currently the usage is looking like this: >>> from dialin import HD >>> hd = HD() >>> hd.events.get_hd_events(23) [] >>> hd.events.ge...

Can you clarify? Events are organized by event id and by time. Currently the usage is looking like this:

>>> from dialin import HD
>>> hd = HD()
>>> hd.events.get_hd_events(23)
[]
>>> hd.events.get_hd_events(23)
[('1684258483', 3, 1, 255)]
>>> hd.events.get_hd_events(23,10)
[('1684258478', 3, 0, 255), ('1684258478', 3, 1, 255), ('1684258479', 4, 0, 255), ('1684258483', 3, 0, 255), ('1684258483', 3, 1, 255)
>>> from dialin.common.hd_defs import HDEventList
>>> hd.events.get_hd_events(HDEventList.HD_EVENT_OPERATION_STATUS.value,10)
[('1684258478', 3, 0, 255), ('1684258478', 3, 1, 255), ('1684258479', 4, 0, 255), ('1684258483', 3, 0, 255), ('1684258483', 3, 1, 255)]

where the user has the option to read the most recent event or a set of the event list.

I'll clarify with V&V. Feedback from john was to change the epoch time to a float.

4:05 pm

jishii (deleted user) and Sean Nash

More
DIALIN-DEN-15196-2
finished reviewing

3:55 pm

Sean Nash

More
Re: DIALIN-DEN-15196-1
commented on review

Looks like you're mixing old and new state data in the dictionary. I would think they would want the new tuples in their own dictionary to have a clean, consistent history of state transitions. Wha...

Looks like you're mixing old and new state data in the dictionary.
I would think they would want the new tuples in their own dictionary to have a clean, consistent history of state transitions.
What does Sarina and her team think about this?

3:50 pm

Sean Nash

More
DIALIN-DEN-15196-3
finished reviewing

3:50 pm

Sean Nash

More
DIALIN-DEN-15196-3
finished reviewing

3:50 pm

Sean Nash

RESOLVED.

RESOLVED.

2:19 pm

Dara Navaei

More
144eba3
changed 1 file
develop, loggingdebugbranch

Bamboo Commit: generated the code change report

- -0
- +8
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

2:17 pm

Michael Garthwaite

More
d6ee216
changed 0 files
develop, loggingdebugbranch

Merge branch 'DEN-15196-DIAL-250' into develop

2:17 pm

Michael Garthwaite

More
252b4fb
changed 1 file
develop, loggingdebugbranch

Merge branch 'DEN-15196-DIAL-251' into develop

- -1
- +2
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py

2:17 pm

Michael Garthwaite

More
09f304a
changed 1 file
develop, loggingdebugbranch

Merge branch 'DEN-15196-DIAL-253' into develop

- -0
- +53
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

2:05 pm

Michael Garthwaite

More
faffee3
changed 0 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more

Merge branch 'staging' into DEN-15196-DIAL-250

2:05 pm

Michael Garthwaite

More
54e33a3
changed 0 files
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 121 more

Merge branch 'staging' into DEN-15196-DIAL-251

1:49 pm

Michael Garthwaite

Ticket didnt specify but a handler has been created to capture the reponse. Thanks!

Ticket didnt specify but a handler has been created to capture the reponse. Thanks!

1:49 pm

Michael Garthwaite

More
d1534b2
changed 1 file
DEN-14679-need-an-override-to-cause-alarm_id_dg_command_invalid_parameter_fault, DEN-14692-need-override-for-alarm_id_hd_cpu_ram_error and 120 more DIALIN-DEN-15196-3

DIAL-253: created handler for alarm list response.

- -0
- +53
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

1:31 pm

Dara Navaei

More
e12cce7
changed 1 file
develop, loggingdebugbranch

Bamboo Commit: generated the code change report

- -2
- +2
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-20 06:11 -0700