Activity dialin/

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	21
Last Commit:	19 Nov 25
Commits this week:	0

Lines of code count not available

Commit Activity

last updated a few seconds ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Friday 18 Aug 2023

5:46 pm

Dara Navaei

More
cb13063
changed 33 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 84 more DIALIN-DIAL-277-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -6
- +6
/dialin/common/alarm_defs.py
- History
- Source
- Diff
/dialin/common/alarm_defs.py
- -2
- +2
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py
- -2
- +2
/dialin/common/msg_defs.py
- History
- Source
- Diff
/dialin/common/msg_defs.py
- -4
- +4
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -1
- +1
/dialin/dg/alarms.py
- History
- Source
- Diff
/dialin/dg/alarms.py
- -1
- +1
/dialin/dg/cpld.py
- History
- Source
- Diff
/dialin/dg/cpld.py
- -1
- +1
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py
- -2
- +2
/dialin/dg/events.py
- History
- Source
- Diff
/dialin/dg/events.py
- -1
- +1
/dialin/dg/fluid_leak.py
- History
- Source
- Diff
/dialin/dg/fluid_leak.py
- -1
- +1
/dialin/dg/hd_proxy.py
- History
- Source
- Diff
/dialin/dg/hd_proxy.py
- -2
- +2
/dialin/dg/heaters.py
- History
- Source
- Diff
/dialin/dg/heaters.py
- -2
- +2
/dialin/dg/load_cells.py
- History
- Source
- Diff
/dialin/dg/load_cells.py
- -2
- +2
/dialin/dg/reservoirs.py
- History
- Source
- Diff
/dialin/dg/reservoirs.py
- -1
- +1
/dialin/dg/rtc.py
- History
- Source
- Diff
/dialin/dg/rtc.py
- -1
- +1
/dialin/dg/samplewater.py
- History
- Source
- Diff
/dialin/dg/samplewater.py
… 18 more files in changeset.

5:45 pm

Michael Garthwaite

More
DIALIN-DIAL-280-1
Closed

4:43 pm

Michael Garthwaite

More
39b3b08
changed 0 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 84 more

Merge branch 'DIAL-280-reservoir-broadcast-override' into staging

2:39 pm

Tiffany Mejia

RESOLVED

RESOLVED

2:05 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

2:05 pm

Michael Garthwaite

More
facc2a6
changed 1 file
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 85 more DIALIN-DIAL-280-1

DIAL-280: code review comments for alarm defs

- -1
- +1
/dialin/common/alarm_defs.py
- History
- Source
- Diff
/dialin/common/alarm_defs.py

1:38 pm

Tiffany Mejia

RESOLVED

RESOLVED

1:35 pm

Tiffany Mejia

More
Re: DIALIN-DIAL-280-1
commented on review

id 63 is ALARM_ID_AVAILABLE_20

id 63 is ALARM_ID_AVAILABLE_20

12:32 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:32 pm

Michael Garthwaite

More
0ff2920
changed 1 file
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 85 more DIALIN-DIAL-280-1

DIAL-280: updated alarm defs

- -1
- +1
/dialin/common/alarm_defs.py
- History
- Source
- Diff
/dialin/common/alarm_defs.py

12:30 pm

Michael Garthwaite

Moved to hd/buttons. Thanks!

Moved to hd/buttons. Thanks!

12:30 pm

Michael Garthwaite

More
1ffb007
changed 2 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 84 more DIALIN-DIAL-277-1

DIAL-277: moved hd button response from hd_proxy to the buttons sub module

- -20
- +0
/dialin/dg/hd_proxy.py
- History
- Source
- Diff
/dialin/dg/hd_proxy.py
- -1
- +22
/dialin/hd/buttons.py
- History
- Source
- Diff
/dialin/hd/buttons.py

12:04 pm

Dara Navaei

More
DIALIN-DEN-16093-1
started review

DIALIN-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment

DIALIN-DEN-16093_Alarm 97 Conductivity Out OF Range Triggered ON First Fill OF Treatment

11:03 am

Tiffany Mejia

More
Re: DIALIN-DIAL-280-1
commented on review

Alarm ID 129 should be ALARM_ID_HD_BLOOD_LEAK_RECOVERING_PLEASE_WAIT per HD build 224

Alarm ID 129 should be ALARM_ID_HD_BLOOD_LEAK_RECOVERING_PLEASE_WAIT per HD build 224

10:09 am

Sean Nash

I see your point. Issue is that we don't have a UI dialin folder with an HD proxy class (where this function should go). This command is not an HD proxy for DG so doesn't really belong here. I woul...

I see your point. Issue is that we don't have a UI dialin folder with an HD proxy class (where this function should go).
This command is not an HD proxy for DG so doesn't really belong here.
I would maybe put it in hd\buttons.

10:02 am

Michael Garthwaite

DG doesn't need this specifically but this is a HD proxy command. V&V currently needs this to dismiss the prompt on the UI screen. I think in the near future we should reorganize Dialin sub modules...

DG doesn't need this specifically but this is a HD proxy command. V&V currently needs this to dismiss the prompt on the UI screen. I think in the near future we should reorganize Dialin sub modules. Maybe by overrides ( HD, DG, & UI ) and proxy messages ( DG, HD, UI ).

9:45 am

Michael Garthwaite

More
0b8ece9
changed 1 file
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 85 more DIALIN-DIAL-280-1

DIAL-280: fixed typo in dg defs

- -1
- +1
/dialin/common/dg_defs.py
- History
- Source
- Diff
/dialin/common/dg_defs.py

9:43 am

Sean Nash

More
Re: DIALIN-DIAL-277-1
commented on review

Why does DG need this HD proxy command?

Why does DG need this HD proxy command?

Thursday 17 Aug 2023

8:50 pm

Dara Navaei

More
537c1c3
changed 1 file
develop, loggingdebugbranch

Bamboo Commit: generated the code change report

- -90
- +92
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

8:49 pm

Michael Garthwaite

More
9dd60b7
changed 2 files
develop, loggingdebugbranch

Merge branch 'DIAL-280-reservoir-broadcast-override' into develop

- -8
- +8
/dialin/dg/hd_proxy.py
- History
- Source
- Diff
/dialin/dg/hd_proxy.py
- -23
- +23
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

8:49 pm

Michael Garthwaite

More
918df13
changed 3 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 85 more DIALIN-DIAL-280-1

DIAL-280: fixes after syncing

- -0
- +1
/dialin/common/alarm_defs.py
- History
- Source
- Diff
/dialin/common/alarm_defs.py
- -1
- +1
/dialin/common/msg_defs.py
- History
- Source
- Diff
/dialin/common/msg_defs.py
- -1
- +3
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py

8:36 pm

Michael Garthwaite

More
5cfee98
changed 32 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 85 more DIALIN-DIAL-280-1

DIAL-280: Alarm and MSG_ID sync

- -15
- +16
/dialin/common/alarm_defs.py
- History
- Source
- Diff
/dialin/common/alarm_defs.py
- -21
- +21
/dialin/common/msg_defs.py
- History
- Source
- Diff
/dialin/common/msg_defs.py
- -83
- +79
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -1
- +1
/dialin/dg/alarms.py
- History
- Source
- Diff
/dialin/dg/alarms.py
- -1
- +1
/dialin/dg/cpld.py
- History
- Source
- Diff
/dialin/dg/cpld.py
- -3
- +3
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py
- -1
- +1
/dialin/dg/events.py
- History
- Source
- Diff
/dialin/dg/events.py
- -1
- +1
/dialin/dg/fluid_leak.py
- History
- Source
- Diff
/dialin/dg/fluid_leak.py
- -8
- +8
/dialin/dg/hd_proxy.py
- History
- Source
- Diff
/dialin/dg/hd_proxy.py
- -1
- +1
/dialin/dg/heaters.py
- History
- Source
- Diff
/dialin/dg/heaters.py
- -2
- +2
/dialin/dg/load_cells.py
- History
- Source
- Diff
/dialin/dg/load_cells.py
- -1
- +1
/dialin/dg/reservoirs.py
- History
- Source
- Diff
/dialin/dg/reservoirs.py
- -1
- +1
/dialin/dg/rtc.py
- History
- Source
- Diff
/dialin/dg/rtc.py
- -1
- +1
/dialin/dg/samplewater.py
- History
- Source
- Diff
/dialin/dg/samplewater.py
- -1
- +1
/dialin/dg/valves.py
- History
- Source
- Diff
/dialin/dg/valves.py
… 17 more files in changeset.

8:18 pm

Michael Garthwaite

More
84f0191
changed 2 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 85 more DIALIN-DIAL-280-1

DIAL-280: Reservoir data broadcast override.

- -0
- +1
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -0
- +38
/dialin/dg/reservoirs.py
- History
- Source
- Diff
/dialin/dg/reservoirs.py

8:04 pm

Dara Navaei

More
DIALIN-DIAL-280-1
started review

DIALIN-DIAL-280_Reservoir Broadcast Override

DIALIN-DIAL-280_Reservoir Broadcast Override

7:39 pm

Michael Garthwaite

More
3317ac6
changed 3 files
DEN-14706-need-mechanism-for-alarm_id_can_message_not_acked-and-alarm_id_dg_can_message_not_acked, DEN-16242-pressure-limit-request-fix and 85 more DIALIN-DEN-14706-1

DEN-14706: Dialin handling of Pending ACK overrides

- -0
- +3
/dialin/common/msg_ids.py
- History
- Source
- Diff
/dialin/common/msg_ids.py
- -0
- +39
/dialin/dg/dialysate_generator.py
- History
- Source
- Diff
/dialin/dg/dialysate_generator.py
- -0
- +39
/dialin/hd/hemodialysis_device.py
- History
- Source
- Diff
/dialin/hd/hemodialysis_device.py

6:04 pm

Dara Navaei

More
DIALIN-DEN-14706-1
started review

DIALIN-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked

DIALIN-DEN-14706_Need Mechanism For Alarm ID Can Message Not Acked And Alarm ID DG Can Message Not Acked

5:26 pm

Michael Garthwaite

More
1b14a5c
changed 0 files
develop, loggingdebugbranch

Merge branch 'DIAL-277-watchdog-override-for-dg' into develop

5:25 pm

Michael Garthwaite

More
a434f65
changed 2 files
DEN-16242-pressure-limit-request-fix, DEN-16309-heat-disinfect-has-spikes-in-temperature-near-95c-which-will-cause-water-to-boil-at and 84 more DIALIN-DIAL-277-1

DIAL-277: fixed power off messages on ui and hd proxies.

- -0
- +1
/dialin/dg/hd_proxy.py
- History
- Source
- Diff
/dialin/dg/hd_proxy.py
- -12
- +5
/dialin/hd/ui_proxy.py
- History
- Source
- Diff
/dialin/hd/ui_proxy.py

4:22 pm

Dara Navaei

More
6dd0fc1
changed 1 file
develop, loggingdebugbranch

Bamboo Commit: generated the code change report

- -0
- +2
/tools/Code_Report.csv
- History
- Source
- Diff
/tools/Code_Report.csv

4:20 pm

Michael Garthwaite

More
919abff
changed 0 files
develop, loggingdebugbranch

Merge branch 'DIAL-277-watchdog-override-for-dg' into develop

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-04-16 07:22 -0700