dialin

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 23 Oct 2023
8:46 am

Michael Garthwaite

Merge branch 'staging'

Options
8:45 am

Michael Garthwaite

Merge branch 'DENBUG-126-usage-record-crc-override-failed' into staging

Options
8:44 am

Michael Garthwaite

8:44 am

Dara Navaei

Friday 20 Oct 2023
1:50 pm

Sean Nash

1:02 pm

Michael Garthwaite

Merge branch 'DENBUG-126-usage-record-crc-override-failed' into develop

Options
1:01 pm

Michael Garthwaite

DENBUG-126: fixed versioning string.

Options
    • -1
    • +1
    /setup.py
12:33 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /dialin/common/hd_defs.py
    • -2
    • +2
    /dialin/common/ui_defs.py
    • -2
    • +2
    /dialin/ui/dg_simulator.py
    • -2
    • +2
    /dialin/ui/hd_simulator.py
12:33 pm

Behrouz NematiPour

Merge branch 'DEN-16454-UI-VD-S106_fix_update_test_pt1' into develop

Options
    • -5
    • +39
    /dialin/ui/hd_simulator.py
12:31 pm

Behrouz NematiPour

Merge remote-tracking branch 'origin/DEN-16454-UI-VD-S106_fix_update_test_pt1' into staging

Options
    • -5
    • +39
    /dialin/ui/hd_simulator.py
10:54 am

Michael Garthwaite

Merge branch 'DENBUG-126-usage-record-crc-override-failed' into develop

Options
10:54 am

Michael Garthwaite

DENBUG-126: updated NV ops enums to be in sync with FW values.

Options
    • -6
    • +6
    /dialin/utils/nv_ops_utils.py
10:46 am

Dara Navaei

DIALIN-DENBUG-126_Usage Record Crc Override Failed
DIALIN-DENBUG-126_Usage Record Crc Override Failed
10:26 am

Michael Garthwaite

Merge branch 'staging'

Options
10:12 am

Behrouz NematiPour

10:11 am

Behrouz NematiPour and msuleiman  (deleted user)

Thursday 19 Oct 2023
4:16 pm

Michael Garthwaite

4:16 pm

Michael Garthwaite

Resolved.

Resolved.

4:16 pm

Michael Garthwaite

Resolved.

Resolved.

4:15 pm

Michael Garthwaite

Resolved.

Resolved.

4:14 pm

vduong  (deleted user)

Done.

Done.

4:14 pm

vduong  (deleted user)

All set. I have reverted it

All set. I have reverted it

4:13 pm

Vy <vduong@sunriselabs.com>

DEN-16465: Updated - TestSuites:Integration testing update

Re-add the parameters removed based on CR comment

Remove extra newline

Options
    • -1
    • +0
    /dialin/common/hd_defs.py
    • -4
    • +4
    /dialin/ui/hd_simulator.py
4:08 pm

Behrouz NematiPour

good point. Vy will fix it.

good point.
Vy will fix it.

4:07 pm

Behrouz NematiPour

Michael Garthwaite Ui code is frozen and we cannot change the UI code, so matched with what currently exists in UI. The attempt was to fix the integration tests, and we did not go over all the mess...

Michael Garthwaite
Ui code is frozen and we cannot change the UI code, so matched with what currently exists in UI.
The attempt was to fix the integration tests, and we did not go over all the messages API to fix them.
We can have it done later when have more time.

3:42 pm

Michael Garthwaite

If the UI can ignore the fields, then why does dialin need to match the UI?

If the UI can ignore the fields, then why does dialin need to match the UI?

3:41 pm

Behrouz NematiPour

UI will ignore the last two values, which is not using it. FW can add extra fields, but for now if UI don't use it or does not have to use it will just ignore.

UI will ignore the last two values, which is not using it.
FW can add extra fields, but for now if UI don't use it or does not have to use it will just ignore.

3:38 pm

Michael Garthwaite

this message structure is in Release FW. What is the UI going to with the incorrect message size?

this message structure is in Release FW. What is the UI going to with the incorrect message size?

3:37 pm

Behrouz NematiPour

Michael Garthwaite we needed to match it with UI and since UI code is freeze.

Michael Garthwaite
we needed to match it with UI and since UI code is freeze.

3:35 pm

Michael Garthwaite

Missing two fields. Current DG FW has MSG_ID_DG_HEATERS_DATA = 0x2C as /// Heaters data structure. typedef struct F32 mainPrimayHeaterDC; ///< Main primary heater DC F32 smallPrimaryHeaterDC; ///...

Missing two fields. Current DG FW has MSG_ID_DG_HEATERS_DATA = 0x2C as

/// Heaters data structure.
typedef struct

F32 mainPrimayHeaterDC; ///< Main primary heater DC
F32 smallPrimaryHeaterDC; ///< Small primary heater DC
F32 trimmerHeaterDC; ///< Trimmer heater DC
F32 primaryTargetTemp; ///< Primary heater target temperature
F32 trimmerTargetTemp; ///< Trimmer heater target temperature
U32 primaryHeaterState; ///< Primary heater state
U32 trimmerHeaterState; ///< Trimmer heater state
F32 primaryEfficiency; ///< Primary heater efficiency
F32 primaryCalcTargetTemp; ///< Primary heater calculated target temperature
F32 trimmerCalcCurrentTemp; ///< Trimmer heater calculated current temperature
U32 trimmerUseLastDC; ///< Trimmer heater use last duty cycle
F32 previsouFlow; ///< Trimmer heater previous flow L/min
U32 controlCounter; ///< Trimmer heater control count

HEATERS_DATA_T;