test_calibration.py

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

Done.

Done.

I added them.

I added them.

Where is 0x9D .. 0x9F?

Where is 0x9D .. 0x9F?

These defs should be moved to common/dg_defs.py

These defs should be moved to common/dg_defs.py

DIALIN-DEN-8030_Chemical Disinfect
DIALIN-DEN-8030_Chemical Disinfect
RESOLVED.

RESOLVED.

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

That's a good idea and I think we should do so. Since this code review is quite old I will make that change in my latest branch

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Fixed.

Fixed.

This is Dara's code. Dara will fix in his DIALIN-DEN-8030 branch.

This is Dara's code. Dara will fix in his DIALIN-DEN-8030 branch.

should we create dg_defs file?

should we create dg_defs file?

DIALIN-DEN-8462_Sprint 45
DIALIN-DEN-8462_Sprint 45
Is there a problem with crc_16? Or, what needs to be fixed still?

Is there a problem with crc_16? Or, what needs to be fixed still?

In _init_.py you should add from .checks import * so that someone can import the check from utils without having to know which file it is in

In _init_.py you should add from .checks import * so that someone can import the check from utils without having to know which file it is in

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

If you select Edit Configuration -> "add content roots" in PyCharm, it will automatically add /home/denali/Projects/dialin/ to your path before executing the script and there is no longer a need to...

If you select Edit Configuration -> "add content roots" in PyCharm, it will automatically add /home/denali/Projects/dialin/ to your path before executing the script and there is no longer a need to append to the path in the script. I had selected this option and wasn't having issue running any script.
I've updated all the paths now to support execution from outside of PyCharm.