dialin / tests / unit_tests

test_dg_valves.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 1
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Aug 2020
4:59 pm

Behrouz NematiPour

4:57 pm

plucia  (deleted user) and pmontazemi  (deleted user)

4:54 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:53 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:52 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:47 pm

pmontazemi  (deleted user)

OK.

OK.

4:46 pm

pmontazemi  (deleted user)

OK.

OK.

4:46 pm

pmontazemi  (deleted user)

OK.

OK.

Thursday 27 Aug 2020
12:36 pm

plucia  (deleted user)

RESOLVED

RESOLVED

Wednesday 26 Aug 2020
12:02 pm

plucia  (deleted user)

12:01 pm

Sean Nash and Behrouz NematiPour

11:52 am

Behrouz NematiPour

RESOLVED.

RESOLVED.

11:51 am

plucia  (deleted user)

11:49 am

plucia  (deleted user)

Okay. It's "Projects" now

Okay. It's "Projects" now

11:47 am

Behrouz NematiPour

Reminded him again and he is aware of it and has plan to do so. We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

Reminded him again and he is aware of it and has plan to do so.
We use "Projects" and if meanwhile anyone has a non-updated VM will update the folder name manually for now.

11:29 am

Behrouz NematiPour

Yes I told him to update that. Will remind him again.

Yes I told him to update that.
Will remind him again.

11:28 am

Behrouz NematiPour

Great, RESOLVED

Great,
RESOLVED

11:28 am

Behrouz NematiPour

great, RESOLVED

great,
RESOLVED

10:44 am

plucia  (deleted user)

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

10:41 am

plucia  (deleted user)

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: ...

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

10:40 am

plucia  (deleted user)

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: ...

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

10:33 am

Behrouz NematiPour

Is there a way to get these values right from c code of firmware? Like a scripts which reads the c file and generates this py code.

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

10:33 am

Behrouz NematiPour

Is there a way to get these values right from c code of firmware? Like a scripts which reads the c file and generates this py code.

Is there a way to get these values right from c code of firmware?
Like a scripts which reads the c file and generates this py code.

10:25 am

Behrouz NematiPour

It has been updated in scripts to "Projects"

It has been updated in scripts to "Projects"

10:20 am

Behrouz NematiPour

Tuesday 25 Aug 2020
2:10 pm

Behrouz NematiPour

I tried to remove it but seems like Jira doesn't listen. sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch ...

I tried to remove it but seems like Jira doesn't listen.
sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch I didn't envision at that moment Jira doesn't let us remove it after it has been added.
Fortunately what we currently can do is to only review files in dialin/squish folder.

Thanks,

1:55 pm

Behrouz NematiPour

I have a screen capture that I can't attach here and put in X:\Users\PemanM. As I explained in the image file, I don't quit understand how Squish is managing the last line. Now I removed extra it s...

I have a screen capture that I can't attach here and put in X:\Users\PemanM.
As I explained in the image file, I don't quit understand how Squish is managing the last line.
Now I removed extra it shows no empty line at the EOF but I see there is one, prior to that it was showing one but was actually two.
Squish and Jira have different view.
external editor is showing one empty line though.

1:35 pm

Behrouz NematiPour

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews? Thanks,

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews?
Thanks,

11:46 am

Sean Nash

11:31 am

plucia  (deleted user)

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review