fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged DEN-5855

Merge branch 'DEN-5855-dg-drain-pump-2-of-2' into develop

Merge branch 'DEN-5674-hd-alarm-design-3-of-4' into develop

DEN-5674: Removed obsolete test code.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WLA

RESOLVED in CODE WLA

Done

Done

We should allow MAX value here (1.0).

We should allow MAX value here (1.0).

Yes, we still use it.

Yes, we still use it.

Done

Done

Done

Done

Do we need the variable roPumpPWMDutyCyclePct anymore?

Do we need the variable roPumpPWMDutyCyclePct anymore?

Suggest combining into one line since there is no other use for variable isFlowOutOfRange.

Suggest combining into one line since there is no other use for variable isFlowOutOfRange.

Do we need the conversion from U16 to S32? If we do, suggest combine into one line and remove roFlow variable.

Do we need the conversion from U16 to S32? If we do, suggest combine into one line and remove roFlow variable.

Done

Done

Done

Done