fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Jan 2021
5:57 pm

Sean Nash

errorOccurredStartTime is confusing name considering how it's being used.

errorOccurredStartTime is confusing name considering how it's being used.

4:22 pm

qnguyen  (deleted user)

Added HD_ prefix.

Added HD_ prefix.

4:05 pm

Sean Nash

Let's talk about it. If there's a good reason, fine. But generally I'd like HD and DG to do similar things in the same manner for consistency.

Let's talk about it. If there's a good reason, fine. But generally I'd like HD and DG to do similar things in the same manner for consistency.

4:02 pm

qnguyen  (deleted user)

On the DG side, I move this function into Alarm Management module. I find it better than individually handle them one by one and it still gives flexibility in case we need to handle another persist...

On the DG side, I move this function into Alarm Management module. I find it better than individually handle them one by one and it still gives flexibility in case we need to handle another persistent alarm differently.

3:53 pm

Sean Nash

This does not look compatible with changes to PersistentAlarm module. Does this compile? I see this everywhere. I suspect you changed all of these and just need to push main DG branch.

This does not look compatible with changes to PersistentAlarm module. Does this compile? I see this everywhere. I suspect you changed all of these and just need to push main DG branch.

3:33 pm

Sean Nash

I know these enums are in a header file with "HD" in the name and so the HD_ prefix may seem unnecessary, but I was putting HD_ and DG_ prefixes on mode state enums in case the HD and DG had one or...

I know these enums are in a header file with "HD" in the name and so the HD_ prefix may seem unnecessary, but I was putting HD_ and DG_ prefixes on mode state enums in case the HD and DG had one or more modes with the same name (like Standby) so there would not be a conflict if somebody wanted to include both HD and DG definitions in there module.

2:18 pm

qnguyen  (deleted user)

HD-DEN-6200_HD Disposable Priming Dialyzer Side
HD-DEN-6200_HD Disposable Priming Dialyzer Side
2:10 pm

qnguyen  (deleted user)

DG-DEN-6200_HD Disposable Priming Dialyzer Side
DG-DEN-6200_HD Disposable Priming Dialyzer Side
Monday 04 Jan 2021
11:03 am

Sean Nash

Instead of "if the flag is TRUE", comment should say something like "if disinfect temperature has been reached".

Instead of "if the flag is TRUE", comment should say something like "if disinfect temperature has been reached".

11:01 am

Sean Nash

fabs will indicate a leak even if the volume goes up. Is that what you want here?

fabs will indicate a leak even if the volume goes up. Is that what you want here?

10:59 am

Sean Nash

Add else for s/w fault. Or maybe load cell driver or Reservoirs module should have a generic get weight function for a given reservoir.

Add else for s/w fault. Or maybe load cell driver or Reservoirs module should have a generic get weight function for a given reservoir.

10:57 am

Sean Nash

Change to resEmpty.

Change to resEmpty.

10:56 am

Sean Nash

Not a great name. Should be resFull or something like that.

Not a great name. Should be resFull or something like that.

10:55 am

Sean Nash

Should be an else (or default if you turn this into a switch) that triggers a s/w fault (bad reservoir param).

Should be an else (or default if you turn this into a switch) that triggers a s/w fault (bad reservoir param).

10:53 am

Sean Nash

There should already be an enum for reservoirs somewhere. Use that one.

There should already be an enum for reservoirs somewhere. Use that one.

10:49 am

Sean Nash

Should drain pump be turned off?

Should drain pump be turned off?

10:47 am

Sean Nash

Is ppiPressure being checked here or in global check I saw at top of exec? Since VPi is closed for much of this mode, the global check is probably not right.

Is ppiPressure being checked here or in global check I saw at top of exec? Since VPi is closed for much of this mode, the global check is probably not right.

10:44 am

Sean Nash

Function name is confusing. Change to something like failHeatDisinfection(). Also, this state handler will return DG_HEAT_DISINFECT_STATE_DRAIN_R1 - overriding the complete state being set in your ...

Function name is confusing. Change to something like failHeatDisinfection(). Also, this state handler will return DG_HEAT_DISINFECT_STATE_DRAIN_R1 - overriding the complete state being set in your function.

10:39 am

Sean Nash

Should return boolean. Should return FALSE and not request standby if we are not in heat disinfect mode.

Should return boolean. Should return FALSE and not request standby if we are not in heat disinfect mode.

10:31 am

Sean Nash

Didn't Sunny say we need at least 25 PSI at inlet?

Didn't Sunny say we need at least 25 PSI at inlet?

10:29 am

Sean Nash

I don't see that you're using this status type. Why not just remove it now?

I don't see that you're using this status type. Why not just remove it now?

10:26 am

Sean Nash

I would avoid the \ and new line here. If comment won't align, put comment on line above with ///.

I would avoid the \ and new line here. If comment won't align, put comment on line above with ///.

10:25 am

Sean Nash

Should this return a boolean? What if we're not in heat disinfect mode when this function is called? Should return FALSE then.

Should this return a boolean? What if we're not in heat disinfect mode when this function is called? Should return FALSE then.

10:24 am

Sean Nash

Shouldn't these functions return a boolean? Then assign result to return value instead of always TRUE.

Shouldn't these functions return a boolean? Then assign result to return value instead of always TRUE.

10:21 am

Sean Nash

A lot of these #includes are already in SystemCommMessages.h and so should probably be removed from this area as they are redundant.

A lot of these #includes are already in SystemCommMessages.h and so should probably be removed from this area as they are redundant.

10:18 am

Sean Nash

Can you go ahead and move the rest of these to their respective module .h files and delete this header file from project?

Can you go ahead and move the rest of these to their respective module .h files and delete this header file from project?

10:17 am

Sean Nash

Add TODO on this to restore condition later.

Add TODO on this to restore condition later.

10:16 am

Sean Nash

We're making all comments start with a capital letter globally. I did HD. This is probably the branch that we should do same for DG.

We're making all comments start with a capital letter globally. I did HD. This is probably the branch that we should do same for DG.

10:14 am

Sean Nash

In HD, AlarmDefs.h is always included via common.h which includes AlarmMgmt.h which includes AlarmDefs.h. DG should be same way so you shouldn't need to include it here.

In HD, AlarmDefs.h is always included via common.h which includes AlarmMgmt.h which includes AlarmDefs.h. DG should be same way so you shouldn't need to include it here.

10:10 am

Sean Nash

This arrangement looks odd. Should be desired time / interval. You have double desired time / double interval. Why?

This arrangement looks odd. Should be desired time / interval. You have double desired time / double interval. Why?