fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 15 Jan 2021
11:33 am

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Align variables

Options
    • -1
    • +1
    /PersistentAlarm.c
11:33 am

qnguyen  (deleted user)

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

With the new design of persistent alarm, we no longer need to keep a separate list of persistent alarm id. Therefore, these have been deleted.

11:29 am

qnguyen  (deleted user)

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

11:25 am

pmontazemi  (deleted user)

Why and where were these persistent alarm moved to?

Why and where were these persistent alarm moved to?

11:24 am

pmontazemi  (deleted user)

Remove extra spaces before = sign.

Remove extra spaces before = sign.

11:10 am

Sean Nash

Do we need to wait until we're done with first part of dialysate prime (or at least check to make sure it's already done) before we switch reservoirs?

Do we need to wait until we're done with first part of dialysate prime (or at least check to make sure it's already done) before we switch reservoirs?

11:05 am

Sean Nash

Is half fill appropriate for both reservoirs? I think we need a TODO here to determine the fill volume we want for each reservoir and I believe they will be different in the end so we probably need...

Is half fill appropriate for both reservoirs? I think we need a TODO here to determine the fill volume we want for each reservoir and I believe they will be different in the end so we probably need two #defines here.

11:00 am

Sean Nash

What if DG does not go to drain mode (e.g. DG rejected drain command)? We will get stuck in this state. Let's discuss DG command handling - we may need to add more to DG response so HD can handle t...

What if DG does not go to drain mode (e.g. DG rejected drain command)? We will get stuck in this state. Let's discuss DG command handling - we may need to add more to DG response so HD can handle these types of issues.

10:54 am

Sean Nash

I think we want to be broadcasting priming progress (% complete or maybe est. time (in secs) countdown) during prime (really prime+wet self-tests) so UI can show progress. Peter may have already de...

I think we want to be broadcasting priming progress (% complete or maybe est. time (in secs) countdown) during prime (really prime+wet self-tests) so UI can show progress. Peter may have already defined a msg for this. Consider what else may need to be broadcast during prime for Dialin purposes.

10:48 am

Sean Nash

I know, but the clearing occurs before the mode gets this signal (see signalAlarmUserActionInitiated() in AlarmMgmt.c). So you don't need to clear it again here.

I know, but the clearing occurs before the mode gets this signal (see signalAlarmUserActionInitiated() in AlarmMgmt.c). So you don't need to clear it again here.

10:44 am

pmontazemi  (deleted user)

Where is alarmIsActive[] input in the code?

Where is alarmIsActive[] input in the code?

10:39 am

qnguyen  (deleted user)

Done.

Done.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

I think the flow rate out of range alarm should be handled by the RO pump driver.

I think the flow rate out of range alarm should be handled by the RO pump driver.

10:31 am

qnguyen  (deleted user)

I think this wrapper should stay with DG or HD, so they can have their own implementation.

I think this wrapper should stay with DG or HD, so they can have their own implementation.

10:26 am

Sean Nash

I think we want to drain reservoir all the way now that we're moving away from the straw concept. Let's discuss this.

I think we want to drain reservoir all the way now that we're moving away from the straw concept. Let's discuss this.

10:24 am

Sean Nash

I think clearing off alarm is handled when user chooses an action (resume, ACK, end Tx, ...). I don't think you need to clear these alarms here.

I think clearing off alarm is handled when user chooses an action (resume, ACK, end Tx, ...). I don't think you need to clear these alarms here.

10:21 am

Sean Nash

Why only this one alarm? I think wherever possible, we want to be more general about alarm user actions. If user chooses to end treatment in response to any alarm that didn't block that option, we ...

Why only this one alarm? I think wherever possible, we want to be more general about alarm user actions. If user chooses to end treatment in response to any alarm that didn't block that option, we should allow it.

10:17 am

Sean Nash

Add more constraints. Should not accept start treatment request if we haven't completed all pre-treatment steps through to patient connection at the end.

Add more constraints. Should not accept start treatment request if we haven't completed all pre-treatment steps through to patient connection at the end.

10:15 am

Sean Nash

Do we need to broadcast anything during pre-treatment mode? I think sub-mode states are already broadcast elsewhere, but think about any Dialin needs.

Do we need to broadcast anything during pre-treatment mode? I think sub-mode states are already broadcast elsewhere, but think about any Dialin needs.

10:13 am

Sean Nash

Maybe just call init function above in case other inits get added there?

Maybe just call init function above in case other inits get added there?

10:05 am

Sean Nash

TODO?

TODO?

10:04 am

Sean Nash

Do you think this function should be moved to PersistentAlarm.c?

Do you think this function should be moved to PersistentAlarm.c?

Thursday 14 Jan 2021
7:16 pm

qnguyen  (deleted user)

Updated logic flow to make variable name easier to understand and less confusing.

Updated logic flow to make variable name easier to understand and less confusing.

7:15 pm

Quang Nguyen <qnguyen@diality.com>

DEN-6200: Make start time more clear and fix spelling error

Options
    • -12
    • +25
    /PersistentAlarm.c
    • -2
    • +2
    /PersistentAlarm.h
5:57 pm

Sean Nash

errorOccurredStartTime is confusing name considering how it's being used.

errorOccurredStartTime is confusing name considering how it's being used.

4:22 pm

qnguyen  (deleted user)

Added HD_ prefix.

Added HD_ prefix.