fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Feb 2021
10:56 pm

Dara Navaei

DEN-5980 added DG functions to POST in NVDataMgmt

Options
    • -10
    • +14
    /Accel.c
    • -259
    • +463
    /NVDataMgmt.c
    • -17
    • +19
    /NVDataMgmt.h
    • -2
    • +12
    /NVDataMgmtDGRecords.h
10:56 pm

pmontazemi  (deleted user)

11:58 am

Sean Nash

Is that a rule in our coding standard?

Is that a rule in our coding standard?

11:22 am

Sean Nash

Fixed.

Fixed.

11:21 am

Sean Nash

Fixed.

Fixed.

11:17 am

Sean Nash

Done.

Done.

11:13 am

qnguyen  (deleted user)

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

11:04 am

qnguyen  (deleted user)

Right after the if statement ends.

Right after the if statement ends.

10:59 am

qnguyen  (deleted user)

Mismatch function name.

Mismatch function name.

10:52 am

Sean Nash

Divide by 2 is averaging start and end rates of the ramp so that I can determine estimate of time needed to complete the ramp.

Divide by 2 is averaging start and end rates of the ramp so that I can determine estimate of time needed to complete the ramp.

10:49 am

Sean Nash

Where?

Where?

10:48 am

qnguyen  (deleted user)

Need to review doxygen style in this file.

Need to review doxygen style in this file.

10:48 am

Sean Nash

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

10:47 am

qnguyen  (deleted user)

Remove doxygen comment.

Remove doxygen comment.

10:45 am

Sean Nash

Done.

Done.

10:44 am

Sean Nash

Fixed.

Fixed.

10:36 am

qnguyen  (deleted user)

Mismatch function name.

Mismatch function name.

10:35 am

qnguyen  (deleted user)

Consider changing 60 to SEC_PER_MIN.

Consider changing 60 to SEC_PER_MIN.

Monday 15 Feb 2021
2:01 pm

Dara Navaei

DEN-5980 removed old calibration functions. Added get functions for HD system and service records

Options
    • -66
    • +8
    /Accel.c
    • -2
    • +0
    /Accel.h
    • -168
    • +92
    /NVDataMgmt.c
    • -30
    • +2
    /NVDataMgmt.h
12:10 am

Dara Navaei

DEN-5980 added HD system and service records

Options
    • -24
    • +168
    /NVDataMgmt.c
    • -2
    • +10
    /NVDataMgmt.h
    • -0
    • +28
    /NVDataMgmtHDRecords.h
Saturday 13 Feb 2021
9:45 pm

Dara Navaei

DEN-5980 removed concentrate pumps from HD NVDataMgmt file

Options
    • -1
    • +0
    /NVDataMgmtHDRecords.h
9:43 pm

Dara Navaei

DEN-5980 defined HD calibration record

Options
    • -18
    • +21
    /NVDataMgmt.c
    • -1
    • +0
    /NVDataMgmt.h
9:25 pm

Dara Navaei

DEN-5980 removed the concentrate pumps header file from NVDataMgmt

Options
    • -2
    • +1
    /NVDataMgmt.c
    • -6
    • +3
    /NVDataMgmtDGRecords.h
11:20 am

Dara Navaei

DEN-5980 added calibration structures for HD. Initial commit of NVDataMgmtHDRecords.h

Options
    • -221
    • +195
    /NVDataMgmt.c
    • -375
    • +29
    /NVDataMgmt.h
    • -7
    • +367
    /NVDataMgmtDGRecords.h
    • -0
    • +179
    /NVDataMgmtHDRecords.h
Friday 12 Feb 2021
4:36 pm

Dara Navaei

DEN-5980 added scheduled runs function in the NV

Options
    • -26
    • +8
    /NVDataMgmt.c
12:37 pm

Dara Navaei

Worked on NV data operations

Options
    • -89
    • +302
    /NVDataMgmt.c
    • -12
    • +36
    /NVDataMgmt.h
    • -0
    • +13
    /NVDataMgmtDGRecords.h
    • -1
    • +1
    /RTC.c
9:24 am

qnguyen  (deleted user)

Do we need to reset alarm signal flags?

Do we need to reset alarm signal flags?

Thursday 11 Feb 2021
12:57 pm

Dara Navaei

DEN-5980 cleaned up the code

Options
    • -19
    • +23
    /NVDataMgmt.c
    • -0
    • +3
    /NVDataMgmt.h
11:41 am

Dara Navaei

DEN-5980 added last service record for the NV operations

Options
    • -2
    • +11
    /NVDataMgmt.c
11:17 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.