fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 Feb 2021
8:48 pm

Dara Navaei

DEN-5980 added DG POST functions

Options
    • -229
    • +691
    /NVDataMgmt.c
    • -2
    • +2
    /NVDataMgmt.h
    • -3
    • +9
    /NVDataMgmtDGRecords.h
11:02 am

Sean Nash

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

qnguyen  (deleted user)

This should be part of Non-Volatile Data Management code review. Dara Navaei has added them to the alarm table.

This should be part of Non-Volatile Data Management code review.
Dara Navaei has added them to the alarm table.

10:25 am

qnguyen  (deleted user)

These have been uncommented.

These have been uncommented.

9:25 am

Sean Nash

Why commented out?

Why commented out?

9:24 am

Sean Nash

Need to add these to end of alarm table below.

Need to add these to end of alarm table below.

Tuesday 16 Feb 2021
10:56 pm

Dara Navaei

DEN-5980 added DG functions to POST in NVDataMgmt

Options
    • -10
    • +14
    /Accel.c
    • -259
    • +463
    /NVDataMgmt.c
    • -17
    • +19
    /NVDataMgmt.h
    • -2
    • +12
    /NVDataMgmtDGRecords.h
10:56 pm

pmontazemi  (deleted user)

11:58 am

Sean Nash

Is that a rule in our coding standard?

Is that a rule in our coding standard?

11:22 am

Sean Nash

Fixed.

Fixed.

11:21 am

Sean Nash

Fixed.

Fixed.

11:17 am

Sean Nash

Done.

Done.

11:13 am

qnguyen  (deleted user)

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

11:04 am

qnguyen  (deleted user)

Right after the if statement ends.

Right after the if statement ends.

10:59 am

qnguyen  (deleted user)

Mismatch function name.

Mismatch function name.

10:52 am

Sean Nash

Divide by 2 is averaging start and end rates of the ramp so that I can determine estimate of time needed to complete the ramp.

Divide by 2 is averaging start and end rates of the ramp so that I can determine estimate of time needed to complete the ramp.

10:49 am

Sean Nash

Where?

Where?

10:48 am

qnguyen  (deleted user)

Need to review doxygen style in this file.

Need to review doxygen style in this file.

10:48 am

Sean Nash

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

All alarm user actions are blocked in this sub-mode. Alarm stop signal flag is covered in this reset function.

10:47 am

qnguyen  (deleted user)

Remove doxygen comment.

Remove doxygen comment.

10:45 am

Sean Nash

Done.

Done.