fwcommon

Clone Tools

Stats

Commits this week: 2
Total Committers: 13
Last Commit: 04 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 03 Apr 2021
10:53 am

Dara Navaei

DEN-5980 added a feature to inform the drivers that a new calibration data is available

Options
    • -32
    • +79
    /NVDataMgmt.c
    • -0
    • +2
    /NVDataMgmt.h
    • -2
    • +2
    /NVDataMgmtHDRecords.h
Friday 02 Apr 2021
10:40 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:39 am

pmontazemi  (deleted user)

I am referring to the comment.

I am referring to the comment.

10:39 am

pmontazemi  (deleted user)

I am referring to the comment.

I am referring to the comment.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:50 am

Sean Nash

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

9:50 am

Sean Nash

Compiler will not allow numeric start to a #define name.

Compiler will not allow numeric start to a #define name.

8:46 am

Sean Nash

Done.

Done.

8:44 am

Sean Nash

Done.

Done.

8:42 am

Sean Nash

Done.

Done.

Thursday 01 Apr 2021
3:41 pm

Dara Navaei

DEN-5980 addressed the code review comments

Options
    • -8
    • +5
    /NVDataMgmt.c
    • -0
    • +4
    /RTC.c
10:43 am

pmontazemi  (deleted user)

Replace 0x40 with constant and define it at beginning of *.c file.

Replace 0x40 with constant and define it at beginning of *.c file.

10:43 am

pmontazemi  (deleted user)

Replace 0x3F with constant and define it at beginning of *.c file.

Replace 0x3F with constant and define it at beginning of *.c file.

10:43 am

pmontazemi  (deleted user)

Replace 0x80 with constant and define it at beginning of *.c file.

Replace 0x80 with constant and define it at beginning of *.c file.

10:42 am

pmontazemi  (deleted user)

Use 10 instead of ten (easier to track and compare).

Use 10 instead of ten (easier to track and compare).

10:42 am

pmontazemi  (deleted user)

Use 5 instead of five (easier to track and compare).

Use 5 instead of five (easier to track and compare).

8:50 am

Sean Nash

I think this should be an and because of the "whichever is greater" part of the condition.

I think this should be an and because of the "whichever is greater" part of the condition.

8:49 am

Sean Nash

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to...

I think it should be and. Because it is a "whichever is greater" condition. So if error is 6% but delta is less than 0.1 mL, I would not want to trigger the error because the volume is too small to alarm on a percentage basis. Likewise, if delta is > 0.1 mL but error is < 5%, no alarm.

Monday 29 Mar 2021
10:20 pm

qnguyen  (deleted user)

Should this be an or?

Should this be an or?

10:20 pm

qnguyen  (deleted user)

Should this be an or?

Should this be an or?

10:54 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:53 am

Dara Navaei

It will be addressed in the future stories.

It will be addressed in the future stories.

10:52 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:49 am

Dara Navaei

It will be addressed in the future stories.

It will be addressed in the future stories.

10:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.