fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Apr 2021
10:11 am

Dara Navaei

DEN-5980 addressed a code review comment

Options
    • -1
    • +1
    /NVDataMgmt.c
10:10 am

Dara Navaei

Done.

Done.

10:08 am

Dara Navaei

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

9:38 am

Sean Nash

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

9:21 am

Sean Nash

Done.

Done.

9:21 am

Sean Nash

Done.

Done.

9:19 am

Sean Nash

Good catch. Fixed.

Good catch. Fixed.

9:16 am

Sean Nash

Updated to match DEN-7091.

Updated to match DEN-7091.

9:01 am

Sean Nash

Done.

Done.

9:00 am

Sean Nash

Fixed.

Fixed.

8:59 am

Sean Nash

Done.

Done.

8:53 am

pmontazemi  (deleted user)

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

8:05 am

pmontazemi  (deleted user)

Comments start with capital letter.

Comments start with capital letter.

8:04 am

pmontazemi  (deleted user)

Spell out lc variable as loadCell.

Spell out lc variable as loadCell.

Monday 05 Apr 2021
6:01 pm

qnguyen  (deleted user)

Recommend adding TRUE to the comparison and parenthesis around each condition.

Recommend adding TRUE to the comparison and parenthesis around each condition.

5:05 pm

qnguyen  (deleted user)

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

4:54 pm

qnguyen  (deleted user)

This seems to be an incorrect message ID.

This seems to be an incorrect message ID.

Saturday 03 Apr 2021
6:47 pm

Dara Navaei

I do not know what happened. I brought it back.

I do not know what happened. I brought it back.

6:43 pm

Dara Navaei

I brought it back.

I brought it back.

6:42 pm

Dara Navaei

Done.

Done.

6:41 pm

Dara Navaei

Done.

Done.

6:41 pm

Dara Navaei

Done.

Done.

6:40 pm

Dara Navaei

No, this variable is used to time both the disinfect states.

No, this variable is used to time both the disinfect states.

6:39 pm

Dara Navaei

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

6:38 pm

Dara Navaei

The #defines are aligned.

The #defines are aligned.

6:36 pm

Dara Navaei

These enums are the possible status that can occur during the actual heat disinfect.

These enums are the possible status that can occur during the actual heat disinfect.

6:35 pm

Dara Navaei

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

6:32 pm

Dara Navaei

I added the function to reset the actuators.

I added the function to reset the actuators.

6:31 pm

Dara Navaei

Done.

Done.

6:31 pm

Dara Navaei

I moved the location of the comment.

I moved the location of the comment.