fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-5980 addressed a code review comment

Done.

Done.

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

Yes, they are going to be used in mode flush and chemical disinfect as well as heat disinfect.

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

Any reason why these are in common header? Does anybody else use them? If not, make private to HeatDisinfect module.

Done.

Done.

Done.

Done.

Good catch. Fixed.

Good catch. Fixed.

Updated to match DEN-7091.

Updated to match DEN-7091.

Done.

Done.

Fixed.

Fixed.

Done.

Done.

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

It would be helpful to say which syringe pump controller signal is being passed via all these channels instead of just a channel number.

Comments start with capital letter.

Comments start with capital letter.

Spell out lc variable as loadCell.

Spell out lc variable as loadCell.

Recommend adding TRUE to the comparison and parenthesis around each condition.

Recommend adding TRUE to the comparison and parenthesis around each condition.

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

This seems to be an incorrect message ID.

This seems to be an incorrect message ID.

I do not know what happened. I brought it back.

I do not know what happened. I brought it back.

I brought it back.

I brought it back.

Done.

Done.

Done.

Done.

Done.

Done.

No, this variable is used to time both the disinfect states.

No, this variable is used to time both the disinfect states.

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

The #defines are aligned.

The #defines are aligned.

These enums are the possible status that can occur during the actual heat disinfect.

These enums are the possible status that can occur during the actual heat disinfect.

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

They are both in Water Cancellation Path state. They are separate because hot cancellation requires mix drain.

I added the function to reset the actuators.

I added the function to reset the actuators.

Done.

Done.

I moved the location of the comment.

I moved the location of the comment.