fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 29 Jul 2021
4:42 pm

Dara Navaei

DEN-9054 addressed the code review comments

Options
    • -12
    • +4
    /Common.h
    • -2
    • +1
    /NVDataMgmt.c
4:40 pm

Dara Navaei

Done.

Done.

4:39 pm

Dara Navaei

I removed the enum.

I removed the enum.

4:38 pm

Dara Navaei

These fill volumes will come from non-volatile memory. I also removed the TODOs.

These fill volumes will come from non-volatile memory. I also removed the TODOs.

4:38 pm

Dara Navaei

Done.

Done.

4:35 pm

Dara Navaei

Done.

Done.

4:34 pm

Dara Navaei

Fixed it.

Fixed it.

4:33 pm

Dara Navaei

Done.

Done.

4:28 pm

Dara Navaei

If the calibration data is invalid, the function will raise an alarm. But the all the calibration records that fail CRC test will be in benign values by NVDataMgmt.c so the benign value is taken as...

If the calibration data is invalid, the function will raise an alarm. But the all the calibration records that fail CRC test will be in benign values by NVDataMgmt.c so the benign value is taken as the target flush volume.

4:26 pm

Dara Navaei

This function is called during POST to get all the pertaining calibration data but since the modes do not have have POST states, it was decided to use DrainPump.c to get the calibration information.

This function is called during POST to get all the pertaining calibration data but since the modes do not have have POST states, it was decided to use DrainPump.c to get the calibration information.

4:24 pm

Dara Navaei

Done.

Done.

4:19 pm

Dara Navaei

Bamboo will do the copyrights. It is not turned on right now but it will automatically.

Bamboo will do the copyrights. It is not turned on right now but it will automatically.

4:19 pm

Dara Navaei

Done.

Done.

4:02 pm

Dara Navaei

Done.

Done.

1:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:16 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:13 pm

qnguyen  (deleted user)

Need to have 2 blank lines.

Need to have 2 blank lines.

1:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:24 pm

qnguyen  (deleted user)

Need to add a check if switchId is in valid range.

Need to add a check if switchId is in valid range.

12:23 pm

qnguyen  (deleted user)

Do we need to add copyrights or bamboo will do it?

Do we need to add copyrights or bamboo will do it?

12:20 pm

qnguyen  (deleted user)

Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.

Common has an enumeration (OPN_CLS_STATE_T) that is similar to this. Suggest using from common.

12:14 pm

qnguyen  (deleted user)

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

Should this function move to ModeRecirculate? It does not seem to contain any information related to drain pump.

12:13 pm

qnguyen  (deleted user)

What happens when calibration data is invalid?

What happens when calibration data is invalid?

12:09 pm

qnguyen  (deleted user)

The comment is out-date and need to be updated.

The comment is out-date and need to be updated.

12:05 pm

qnguyen  (deleted user)

Param name is not matched.

Param name is not matched.