fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed.

Fixed.

Variable is in the isAirTrapControlling() function.

Variable is in the isAirTrapControlling() function.

Fixed.

Fixed.

Fixed.

Fixed.

Are we planning to have #defines instead of the numbers?

Are we planning to have #defines instead of the numbers?

What is the plan with these software faults?

What is the plan with these software faults?

I do not see this variable in the function.

I do not see this variable in the function.

Suggest define magic number 0.

Suggest define magic number 0.

HD-DEN-8886_HD DG Dev Self Tests (2 of 2)
HD-DEN-8886_HD DG Dev Self Tests (2 of 2)
RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed the maxBufferLength variable.

Fixed the maxBufferLength variable.

Done.

Done.

Done.

Done.

Unused parameter.

Unused parameter.

Looks like the parameter is not being used.

Looks like the parameter is not being used.

maxBufferLength variable is not needed in this case and the comment is not matched the code. Suggest revert this change to line 2139.

maxBufferLength variable is not needed in this case and the comment is not matched the code.
Suggest revert this change to line 2139.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

The signal is debounced for 50ms. I added a debounce for a longer time.

The signal is debounced for 50ms. I added a debounce for a longer time.

The calibration structures are populated during POST. The initialization will be addressed in DEN-9480.

The calibration structures are populated during POST. The initialization will be addressed in DEN-9480.

Done.

Done.