fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 06 Nov 2021
7:29 pm

Dara Navaei

DEN-9480 addressed the code review comments

Options
    • -13
    • +17
    /Accel.c
    • -10
    • +13
    /RTC.c
    • -0
    • +10
    /RTC.h
4:37 pm

Dara Navaei

Done.

Done.

4:36 pm

Dara Navaei

Done.

Done.

4:23 pm

Dara Navaei

I do not see this mode my local code base. It might have been git.

I do not see this mode my local code base. It might have been git.

4:07 pm

Dara Navaei

Done.

Done.

4:06 pm

Dara Navaei

The drain flow rate does not matter in any of the disinfects. The faster the drain, the better.

The drain flow rate does not matter in any of the disinfects. The faster the drain, the better.

4:04 pm

Dara Navaei

Added the TODO back.

Added the TODO back.

4:03 pm

Dara Navaei

No it is uncommented.

No it is uncommented.

4:00 pm

Dara Navaei

Subtract 0.0 was unnecessary. I deleted it.

Subtract 0.0 was unnecessary. I deleted it.

3:57 pm

Dara Navaei

This was not the right place for the function. I deleted the function.

This was not the right place for the function. I deleted the function.

3:57 pm

Dara Navaei

This function is no longer needed and I deleted it.

This function is no longer needed and I deleted it.

3:56 pm

Dara Navaei

With 2400 RPM the flow rate was ~2497.718 mL/min. I changed the target RPM to 2300.

With 2400 RPM the flow rate was ~2497.718 mL/min. I changed the target RPM to 2300.

3:48 pm

Dara Navaei

Friday 05 Nov 2021
7:09 pm

Behrouz NematiPour

I couldn't find TBD anywhere in the code!!! What is TBD?

I couldn't find TBD anywhere in the code!!!
What is TBD?

11:39 am

Sean Nash

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

We want 2400 mL/min. Will this RPM speed result in desired flow rate?

11:17 am

Sean Nash

Who would call this function?

Who would call this function?

11:13 am

Sean Nash

We're saving fill data to RTC RAM every 50ms?

We're saving fill data to RTC RAM every 50ms?

11:09 am

Sean Nash

What's happening here? Why subtract 0?

What's happening here? Why subtract 0?

Thursday 04 Nov 2021
11:45 am

Sean Nash

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

Should this be a DEBUG_DENALI comment so Bamboo will prevent a build?

11:44 am

Sean Nash

Should we keep the TODO for this?

Should we keep the TODO for this?

11:40 am

Sean Nash

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

Does 2400 RPM get us 2400 mL/min drain rate? It's the rate that we want to be 2400.

11:26 am

Sean Nash

Make a private definitions section above private data and move this there.

Make a private definitions section above private data and move this there.

11:25 am

Sean Nash

Should this module be removed (replaced by ModeGenIdle)?

Should this module be removed (replaced by ModeGenIdle)?

10:34 am

Sean Nash

Handling of passive notification is removed in my branch.

Handling of passive notification is removed in my branch.

10:33 am

Sean Nash

Debug code is removed in my branch. Should s/w fault here I think.

Debug code is removed in my branch. Should s/w fault here I think.

10:33 am

Sean Nash

This is removed in my branch.

This is removed in my branch.

10:03 am

Sean Nash

Make a build switch to disable ACK alarms.

Make a build switch to disable ACK alarms.

10:00 am

Sean Nash

Can the two datas be memcpy'd as EVENT_DATA_Ts instead of U32 and EVENT_DATAS_T separately?

Can the two datas be memcpy'd as EVENT_DATA_Ts instead of U32 and EVENT_DATAS_T separately?

9:58 am

Sean Nash

Let's finish optimizing broadcasts.

Let's finish optimizing broadcasts.

9:48 am

Sean Nash

There are now 2 DG flow sensors (FMP and FMD).

There are now 2 DG flow sensors (FMP and FMD).