fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-9480 addressed the code review comments

I added an else to FALSE the persistent alarm.

I added an else to FALSE the persistent alarm.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

Done.

DEN-9906 added the benign section for the dialysate flow sensor

That if has an extra condition (beyond pump is not on). So alarm persistence is only reset if other condition is met. If other condition is not met, persistence is left in limbo.

That if has an extra condition (beyond pump is not on). So alarm persistence is only reset if other condition is met. If other condition is not met, persistence is left in limbo.

Done.

Done.

I removed it.

I removed it.

Done.

Done.

Done.

Done.

If we are in a non-heating mode, the heaters do not need to be on and we should not be in this state.

If we are in a non-heating mode, the heaters do not need to be on and we should not be in this state.

This part is under development and I have been working on the happy path of the heaters. I added a build switch for now.

This part is under development and I have been working on the happy path of the heaters. I added a build switch for now.

This is heaters monitor. This code is not going to be removed but I have commented it to disable any monitoring while the heaters are being monitored. I added a build switch for it.

This is heaters monitor. This code is not going to be removed but I have commented it to disable any monitoring while the heaters are being monitored. I added a build switch for it.

Done.

Done.

I removed it.

I removed it.

Done.

Done.

I uncommented it.

I uncommented it.

If the pump is not on, the monitor checks the voltage to make sure it is reading 0. That code is a couple of lines above.

If the pump is not on, the monitor checks the voltage to make sure it is reading 0. That code is a couple of lines above.

No, the voltage is monitored in the RO pump module.

No, the voltage is monitored in the RO pump module.

This function is no longer needed.

This function is no longer needed.

Can this be optimized later?

Can this be optimized later?

In @details Inputs and Outputs, replace heatersVoltageMonitorTimeCounter with voltageMonitorTimeCounter.

In @details Inputs and Outputs, replace heatersVoltageMonitorTimeCounter with voltageMonitorTimeCounter.

Add fansStatus to @details Inputs, since it is read at line 593

Add fansStatus to @details Inputs, since it is read at line 593

In @details Inputs and Outputs, change dataPublishCounter to fansPublishCounter

In @details Inputs and Outputs, change dataPublishCounter to fansPublishCounter

In @details Outputs, remove "fansStatus" because I don't think we count the local variables as outputs

In @details Outputs, remove "fansStatus" because I don't think we count the local variables as outputs

drainPumpDAC on line 611 should be added to @detail inputs?

drainPumpDAC on line 611 should be added to @detail inputs?