Activity fwcommon/

2:57 pm

Dara Navaei

More
a89fd55
changed 6 files
cdc-demo-branch-218, demo_branch and 3 more DG-DEN-15336-1

Merged staging and resolved merge conflicts

- -17
- +21
/Accel.c
- History
- Source
- Diff
/Accel.c
- -6
- +6
/MessageSupport.c
- History
- Source
- Diff
/MessageSupport.c
- -6
- +6
/MessageSupport.h
- History
- Source
- Diff
/MessageSupport.h
- -1
- +1
/NVDataMgmt.c
- History
- Source
- Diff
/NVDataMgmt.c
- -1
- +1
/NVDataMgmtDGRecords.h
- History
- Source
- Diff
/NVDataMgmtDGRecords.h
- -10
- +21
/RTC.c
- History
- Source
- Diff
/RTC.c

12:56 pm

Hung Nguyen <hnguyen@diality.com>

More
d2fbaf3
changed 0 files
cdc-demo-branch-218, demo_branch and 3 more

Merge branch 'develop' of ssh://dvm-linux02:7999/comm/fwcommon into develop

11:23 am

Dara Navaei

More
DG-DEN-9480-1
Closed

10:57 am

Dara Navaei

More
17fdefc
changed 9 files
DEN-11098-implement-hd-pre-treatment-mode-update, DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2 and 131 more HD-DEN-9906-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
/Accel.c
- History
- Source
- Diff
/Accel.c
- -2
- +2
/Common.h
- History
- Source
- Diff
/Common.h
- -0
- +16
/MessageSupport.c
- History
- Source
- Diff
/MessageSupport.c
- -0
- +16
/MessageSupport.h
- History
- Source
- Diff
/MessageSupport.h
- -1
- +1
/NVDataMgmt.c
- History
- Source
- Diff
/NVDataMgmt.c
- -1
- +1
/NVDataMgmt.h
- History
- Source
- Diff
/NVDataMgmt.h
- -1
- +1
/NVDataMgmtDGRecords.h
- History
- Source
- Diff
/NVDataMgmtDGRecords.h
- -1
- +1
/RTC.c
- History
- Source
- Diff
/RTC.c
- -2
- +2
/RTC.h
- History
- Source
- Diff
/RTC.h

10:54 am

hnguyen (deleted user) and Sean Nash

More
DG-DEN-9480-1
finished reviewing

10:37 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:36 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:36 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

10:35 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED IN CODE WALKTHROUGH

9:08 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

9:07 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

9:05 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

9:04 pm

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

5:37 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

3:38 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

2:35 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

2:29 pm

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
commented on review

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

1:38 pm

Hung Nguyen <hnguyen@diality.com>

More
de7e693
changed 1 file
cdc-demo-branch-218, demo_branch and 3 more

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

- -3
- +6
/NVDataMgmt.c
- History
- Source
- Diff
/NVDataMgmt.c

1:38 pm

Sean Nash

More
67c10c0
changed 1 file
cdc-demo-branch-218, demo_branch and 3 more

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

- -3
- +6
/NVDataMgmt.c
- History
- Source
- Diff
/NVDataMgmt.c

11:17 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:16 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:09 am

Dara Navaei

More
Re: DG-DEN-9480-1
replied to Sean Nash

Done.

11:06 am

Dara Navaei

More
Re: DG-DEN-9480-1
replied to Sean Nash

Removed it.

11:06 am

hnguyen (deleted user)

More
Re: HD-DEN-9906-1
replied to Sean Nash

RESOLVED in CODE WALKTHROUGH

11:02 am

Sean Nash

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH.

11:02 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH

11:02 am

Dara Navaei

More
dbb3d68
changed 1 file
DEN-11098-implement-hd-pre-treatment-mode-update, DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2 and 132 more DG-DEN-9480-1

DEN-9480 addressed the code review commenst

- -1
- +1
/Accel.c
- History
- Source
- Diff
/Accel.c

11:01 am

Dara Navaei

More
Re: DG-DEN-9480-1
replied to hnguyen (deleted user)

Done.

10:59 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH

10:57 am

hnguyen (deleted user)

More
Re: DG-DEN-9480-1
replied to Dara Navaei

RESOLVED in CODE WALKTHROUGH

fwcommon

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Dara Navaei

Hung Nguyen <hnguyen@diality.com>

Dara Navaei

Dara Navaei

hnguyen (deleted user) and Sean Nash

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

Dara Navaei

Dara Navaei

Dara Navaei

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

hnguyen (deleted user)

Hung Nguyen <hnguyen@diality.com>

Sean Nash

Sean Nash

Sean Nash

Dara Navaei

Dara Navaei

hnguyen (deleted user)

Sean Nash

hnguyen (deleted user)

Dara Navaei

Dara Navaei

hnguyen (deleted user)

hnguyen (deleted user)