fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merged staging and resolved merge conflicts

Merge branch 'develop' of ssh://dvm-linux02:7999/comm/fwcommon into develop

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Done.

Done.

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

The const is an optional step in our code. Plus these are the local variables and their values are not changed inside the function.

Done.

Done.

Done.

Done.

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

Variable reservoirDataPublicationTimerCounter is missing in the @detail Inputs and Output

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

I am not sure why you removed the "const" from dialysateTemp and targetTemp?

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

Added "pressuresDataPublicationTimerCounter" variable to @details Outputs

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

The state variable valvesStatesPublicationTimerCounter was read, increment, then write. Therefore, it needs to be added to the @details Outputs.

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

Merge branch 'DEN-9906-hd_dev-flow-measurement-changes' into develop

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Removed it.

Removed it.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

DEN-9480 addressed the code review commenst

Done.

Done.

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH

RESOLVED in CODE WALKTHROUGH