fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 30 Dec 2021
7:12 pm

Dara Navaei

DEN-11114 fixed the blood leak calibration structure

Options
    • -2
    • +2
    /NVDataMgmtHDRecords.h
1:14 pm

Sean Nash

Update message list with latest data details.

Update message list with latest data details.

1:13 pm

Sean Nash

Update message list with latest broadcast msg data details.

Update message list with latest broadcast msg data details.

1:09 pm

Sean Nash

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

1:08 pm

Sean Nash

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buf...

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

1:03 pm

Sean Nash

.crc?

.crc?

1:00 pm

Sean Nash

1 and 0 is not clear. Better to say FIFO send and reset.

1 and 0 is not clear. Better to say FIFO send and reset.

12:43 pm

Sean Nash

Create and trigger new alarm.

Create and trigger new alarm.

12:42 pm

Sean Nash

.crc?

.crc?

12:40 pm

Sean Nash

Recommend changing > to >= and then removing the - 1.

Recommend changing > to >= and then removing the - 1.

12:28 pm

Sean Nash

Please update message list details for this broadcast msg.

Please update message list details for this broadcast msg.

12:24 pm

Sean Nash

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

12:23 pm

Sean Nash

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

12:21 pm

Sean Nash

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

9:25 am

Dara Navaei

DEN-11114 updated the DG and HD NV data get enums

Options
    • -1
    • +1
    /NVDataMgmt.c
    • -3
    • +2
    /NVDataMgmtDGRecords.h
    • -3
    • +3
    /NVDataMgmtHDRecords.h
Wednesday 29 Dec 2021
11:48 pm

Dara Navaei

DEN-11114 updated the name of the NV data get enums

Options
    • -2
    • +2
    /NVDataMgmt.c
    • -3
    • +3
    /NVDataMgmtHDRecords.h
11:08 pm

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/comm/fwcommon into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

Options
11:08 pm

Dara Navaei

DEN-11114 worked on the HD blood leak calibration record

Options
    • -12
    • +108
    /NVDataMgmt.c
    • -0
    • +2
    /NVDataMgmt.h
    • -0
    • +8
    /NVDataMgmtDGRecords.h
    • -1
    • +17
    /NVDataMgmtHDRecords.h
Monday 20 Dec 2021
10:58 am

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
Friday 17 Dec 2021
3:44 pm

Sean Nash

DEN-11114: Fixed alarm trigger macros to force data type enums to be interpreted as U32s.

Options
    • -6
    • +6
    /Common.h
Wednesday 15 Dec 2021
1:02 pm

Hung Nguyen <hnguyen@diality.com>

Merge branch 'develop' of ssh://dvm-linux02:7999/comm/fwcommon into develop

Options
10:49 am

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
8:48 am

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/comm/fwcommon into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

Options
8:47 am

Dara Navaei

DEN-11114 added a large number for inifinity

Options
    • -0
    • +1
    /Common.h
Monday 13 Dec 2021
4:26 pm

Dara Navaei

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Options
4:25 pm

Dara Navaei

DEN-1114 updated the persistent alarm

Options
    • -1
    • +1
    /PersistentAlarm.c
Friday 10 Dec 2021
2:59 pm

Dara Navaei

Merged DEN-11114 and resolved the merge conflicts

Options
10:32 am

Dara Navaei

DEN-11114 removed the repeated code in the Accel.c file

Options
    • -8
    • +0
    /Accel.c
Thursday 02 Dec 2021
10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.