fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-11114 worked on NV data management

Done.

Done.

Fixed it.

Fixed it.

Done.

Done.

Done.

Done.

Done.

Done.

DEN-11114 fixed the blood leak calibration structure

Update message list with latest data details.

Update message list with latest data details.

Update message list with latest broadcast msg data details.

Update message list with latest broadcast msg data details.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

We don't need to calculate digit count - just use strlen(tempCharBuffer) after sprintf creates your string.

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buf...

I would set this to at least 11 because you are using sprintf to create an unsigned integer string (max is 10 digits + 1 zero terminator) and we want to make sure we give sprintf a large enough buffer to populate - otherwise it will overwrite memory.

.crc?

.crc?

1 and 0 is not clear. Better to say FIFO send and reset.

1 and 0 is not clear. Better to say FIFO send and reset.

Create and trigger new alarm.

Create and trigger new alarm.

.crc?

.crc?

Recommend changing > to >= and then removing the - 1.

Recommend changing > to >= and then removing the - 1.

Please update message list details for this broadcast msg.

Please update message list details for this broadcast msg.

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

If h/w component is not required to have a calibration, we shouldn't alarm here - right?

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

We should verify bufferLength is >= to cal section byte size before doing this memcpy - otherwise, we will be overwriting memory.

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

Is CRC check on individual cal section done elsewhere or should it be considered here as well?

DEN-11114 updated the DG and HD NV data get enums

DEN-11114 updated the name of the NV data get enums

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/comm/fwcommon into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

DEN-11114 worked on the HD blood leak calibration record

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

DEN-11114: Fixed alarm trigger macros to force data type enums to be interpreted as U32s.

Merge branch 'develop' of ssh://dvm-linux02:7999/comm/fwcommon into develop

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' into develop

Merge branch 'DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2' of ssh://dvm-linux02:7999/comm/fwcommon into DEN-11114-dg_dev-dg-dialysate-temperature-control-2-of-2

DEN-11114 added a large number for inifinity