fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 31 Jan 2022
2:04 pm

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
    • -37
    • +28
    /NVDataMgmt.c
2:02 pm

Dara Navaei

merged DEN-11750

Options
    • -5
    • +7
    /Accel.c
    • -16
    • +74
    /NVDataMgmt.c
2:01 pm

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' of ssh://dvm-linux02:7999/comm/fwcommon into DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up

Options
    • -2
    • +4
    /NVDataMgmt.c
2:01 pm

Dara Navaei

DEN-11750 added more software configurations

Options
    • -37
    • +28
    /NVDataMgmt.c
    • -5
    • +7
    /NVDataMgmt.h
    • -0
    • +11
    /NVDataMgmtHDRecords.h
1:58 pm

hnguyen  (deleted user)

Renamed forceAtStartOfPriming to forceAtEndOfSeek.

Renamed forceAtStartOfPriming to forceAtEndOfSeek.

1:50 pm

hnguyen  (deleted user)

Done. Removed max bolus rate.

Done. Removed max bolus rate.

1:49 pm

hnguyen  (deleted user)

Yes, we use fixed rate. Removed min/max bolus rates

Yes, we use fixed rate. Removed min/max bolus rates

1:38 pm

hnguyen  (deleted user)

Done. Removed the 2nd part ( && ( getSyringePumpVolumeDelivered() < bolusVol )

Done. Removed the 2nd part ( && ( getSyringePumpVolumeDelivered() < bolusVol )

1:31 pm

hnguyen  (deleted user)

Done.

Done.

1:28 pm

hnguyen  (deleted user)

Done.

Done.

1:26 pm

hnguyen  (deleted user)

Done.

Done.

1:26 pm

hnguyen  (deleted user)

Done.

Done.

10:50 am

Sean Nash

I think we need some re-start code like this for bolus in SelfTests.c for when a recoverable alarm occurs during wet self-tests (stops pump) and user chooses to resume (pump should restart if bolus...

I think we need some re-start code like this for bolus in SelfTests.c for when a recoverable alarm occurs during wet self-tests (stops pump) and user chooses to resume (pump should restart if bolus not finished).

10:47 am

Sean Nash

I think DEN-11750 branch has a better version of this code. Reconcile this code with DEN-11750.

I think DEN-11750 branch has a better version of this code. Reconcile this code with DEN-11750.

10:36 am

Sean Nash

Why do we need the second part of this condition? When we start wet self tests, bolus volume delivered should be zero.

Why do we need the second part of this condition? When we start wet self tests, bolus volume delivered should be zero.

10:34 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

10:33 am

Sean Nash

Move these includes into user code block above. Cannot make changes outside user code blocks.

Move these includes into user code block above. Cannot make changes outside user code blocks.

10:33 am

Sean Nash

Remove blank line. Cannot make changes outside of user code blocks.

Remove blank line. Cannot make changes outside of user code blocks.

10:32 am

Sean Nash

Remove this blank line. Cannot make changes outside user code blocks.

Remove this blank line. Cannot make changes outside user code blocks.

10:31 am

Sean Nash

Need to uncomment this now that testing is done.

Need to uncomment this now that testing is done.

10:29 am

Sean Nash

Not sure if check for prime empty makes sense. An insufficient Heparin alarm should always occur first, so empty check would be unreachable.

Not sure if check for prime empty makes sense. An insufficient Heparin alarm should always occur first, so empty check would be unreachable.

10:26 am

Sean Nash

I don't think this will work. When you stop pump above, you will leave this state, so you will never get into the if condition below. I think the 1 second delay and check for occlusion should be ha...

I don't think this will work. When you stop pump above, you will leave this state, so you will never get into the if condition below.
I think the 1 second delay and check for occlusion should be handled in the SelfTests.c.

10:24 am

Sean Nash

Why is this commented out? If alarm, need to leave this state (and go to off state).

Why is this commented out? If alarm, need to leave this state (and go to off state).

9:40 am

Sean Nash

Bolus rate is fixed now so no range check is needed. Keep check for home though.

Bolus rate is fixed now so no range check is needed. Keep check for home though.

9:38 am

Sean Nash

Bolus time obsolete.

Bolus time obsolete.

9:38 am

Sean Nash

Max bolus rate is obsolete as it is now fixed.

Max bolus rate is obsolete as it is now fixed.

Friday 28 Jan 2022
2:38 pm

Dara Navaei

1:29 pm

Sean Nash

I think we should say end of seek or before prime instead of start of priming.

I think we should say end of seek or before prime instead of start of priming.

1:28 pm

Sean Nash

This name and comment suggest that threshold is absolute (literally > 0.5V), but threshold is actually a baseline voltage (taken after seek) + 0.5V.

This name and comment suggest that threshold is absolute (literally > 0.5V), but threshold is actually a baseline voltage (taken after seek) + 0.5V.

1:26 pm

Sean Nash

These min/max bolus rates are obsolete now, right?

These min/max bolus rates are obsolete now, right?