fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 17 Feb 2022
9:33 am

Dara Navaei

Merge branch 'DEN-11750-dg_dev-dg-dialysate-temperature-control-tune-up' into develop

Options
Wednesday 16 Feb 2022
11:30 pm

Dara Navaei

DEN-11750 added more HD software configurations

Options
    • -0
    • +3
    /NVDataMgmtHDRecords.h
1:55 pm

Michael Garthwaite

Please see comment below regarding the changes in common from this code review.

Please see comment below regarding the changes in common from this code review.

1:54 pm

Michael Garthwaite

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprin...

Dara and I have found out that this code review for common is misconfigured. The source and destination branches are misconfigured. The branch to review should have been from DEN-11980_sw_dev_sprint_64 and the "branch from" should have been from staging. This code review has staging as the branch to review with master as the "branch review."

12:34 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:34 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:33 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:32 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:32 pm

Michael Garthwaite

Renamed to testSendCurrentTreatmentParameters(). thanks!

Renamed to testSendCurrentTreatmentParameters(). thanks!

12:31 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:31 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:31 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

12:31 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:49 am

hnguyen  (deleted user)

Reinstalled the case statement back to where it was. case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE: handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message );

Reinstalled the case statement back to where it was.
case MSG_ID_HD_FAN_RPM_ALARM_START_TIME_OFFSET_OVERRIDE:
handleTestFansRPMAlarmStartTimeOffsetOverrideRequest( message );

10:13 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

10:13 am

Michael Garthwaite

Updates per code review.

Options
    • -1
    • +0
    /Utilities.c
10:09 am

Sean Nash

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().

Function name is misleading. Sounds like Dialin is sending us new parameters, but it is only requesting current params be sent. I would change to something like testSendCurrentTreatmentParameters().

10:06 am

Sean Nash

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

Check that Dialin has logged in before acting on a Dialin request (TRUE == isTestingActivated()).

10:05 am

Sean Nash

Add a blank line between declarations and code.

Add a blank line between declarations and code.

10:04 am

Sean Nash

Check editor settings. Tabs should be set to 4 spaces.

Check editor settings. Tabs should be set to 4 spaces.

10:04 am

Sean Nash

Remove blank lines.

Remove blank lines.

10:02 am

Sean Nash

Remove blank line.

Remove blank line.

10:02 am

Sean Nash

Remove blank line.

Remove blank line.

10:00 am

Michael Garthwaite

I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.

I believe this was caused from us branching out of master to have develop & staging branches for common. I will review this as this was not expected.

9:59 am

Sean Nash

Add one more blank line here.

Add one more blank line here.

9:59 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

9:50 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:48 am

Sean Nash

Why does it look like you added this table when I know it was there before?

Why does it look like you added this table when I know it was there before?

9:48 am

Sean Nash

I see why you did this - make sure alarm list script(s) by Dara are updated accordingly.

I see why you did this - make sure alarm list script(s) by Dara are updated accordingly.

9:39 am

Sean Nash

Why deleted?

Why deleted?