fwcommon

Clone Tools

Stats

Commits this week: 2
Total Committers: 13
Last Commit: 04 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Mar 2022
2:00 pm

Dara Navaei

DEN-12215 addressed the code reivew comment

Options
    • -1
    • +1
    /NVDataMgmtDGRecords.h
1:45 pm

Dara Navaei

Please do not remove the #defines until the calibration records are updated.

Please do not remove the #defines until the calibration records are updated.

1:41 pm

Dara Navaei

Add doxygen comment.

Add doxygen comment.

1:39 pm

Dara Navaei

Add doxygen comment.

Add doxygen comment.

1:14 pm

Sean Nash

It looks like staging branch has things the way it was too.

It looks like staging branch has things the way it was too.

1:13 pm

hnguyen  (deleted user)

Added internal signal flag handleBadFillFlag

Added internal signal flag handleBadFillFlag

1:04 pm

Sean Nash

Should be since last service (not last treatment).

Should be since last service (not last treatment).

11:00 am

hnguyen  (deleted user)

Removed flush lines

Removed flush lines

11:00 am

hnguyen  (deleted user)

The fillStatus.fillEmptyAcidBottleDetected is set to TRUE to signal drain mode that empty bottle is detected This flag is checked at the end of the drain mode.

The fillStatus.fillEmptyAcidBottleDetected is set to TRUE to signal drain mode that empty bottle is detected
This flag is checked at the end of the drain mode.

10:53 am

hnguyen  (deleted user)

Corrected Initialized in case DG_GEN_IDLE_MODE_STATE_START: // Execute current generation idle state switch ( genIdleState ) { case DG_GEN_IDLE_MODE_STATE_START: badFillState = DG_HANDLE_BAD_FILL_...

Corrected
Initialized in case DG_GEN_IDLE_MODE_STATE_START:

// Execute current generation idle state
switch ( genIdleState )
{
case DG_GEN_IDLE_MODE_STATE_START:
badFillState = DG_HANDLE_BAD_FILL_STATE_START;
genIdleState = handleIdleStartState();
break;

10:43 am

dcox  (deleted user)

This was part of the merge from staging branch.

This was part of the merge from staging branch.

Monday 21 Mar 2022
6:30 pm

hnguyen  (deleted user)

At the end of drain, check for empty bottles

At the end of drain, check for empty bottles

6:24 pm

hnguyen  (deleted user)

Replaced else if ( ( FALSE == isAlarmActive( ALARM_ID_DG_ACID_BOTTLE_LOW_VOLUME ) ) || ( FALSE == isAlarmActive( ALARM_ID_DG_BICARB_BOTTLE_LOW_VOLUME ) ) ) { with else {

Replaced
else if ( ( FALSE == isAlarmActive( ALARM_ID_DG_ACID_BOTTLE_LOW_VOLUME ) ) ||
( FALSE == isAlarmActive( ALARM_ID_DG_BICARB_BOTTLE_LOW_VOLUME ) ) )
{
with
else
{

6:02 pm

hnguyen  (deleted user)

Removed setBottlesNeedPrimeFlag and use function setThisFirstFillFlag().

Removed setBottlesNeedPrimeFlag and use function setThisFirstFillFlag().

5:58 pm

hnguyen  (deleted user)

Removed fillBottlesNeedPrimeFlag and use the existing isThisFirstFill

Removed fillBottlesNeedPrimeFlag and use the existing isThisFirstFill

5:57 pm

hnguyen  (deleted user)

isAvgConductivityOutOfRange is now called in ModeGenIdle

isAvgConductivityOutOfRange is now called in ModeGenIdle

5:48 pm

hnguyen  (deleted user)

Added startFillCmd( targetFillVolumeML, getTargetFillFlowRateLPM() ); // refill to the saved target fill volume (~1500 mL)

Added
startFillCmd( targetFillVolumeML, getTargetFillFlowRateLPM() ); // refill to the saved target fill volume (~1500 mL)

5:14 pm

hnguyen  (deleted user)

Assigned MSG_ID_DG_FILL_MODE_DATA = 0xAE, ///< DG broadcast of fill mode data such as used acid & bicarb volume Updated Message List.xlsx (Denali Tab, Row = 142) with 0xAE00 DG Fill Mode Data

Assigned MSG_ID_DG_FILL_MODE_DATA = 0xAE, ///< DG broadcast of fill mode data such as used acid & bicarb volume
Updated Message List.xlsx (Denali Tab, Row = 142) with 0xAE00 DG Fill Mode Data

12:19 pm

Dara Navaei

Merge branch 'DEN-12224-dg_hd_dev-switches-monitor' into develop

Options
    • -10
    • +10
    /Accel.c
    • -77
    • +85
    /NVDataMgmt.c
10:20 am

Dara Navaei

DEN-12224 added the release build defines

Options
    • -0
    • +5
    /NVDataMgmt.c
10:17 am

Dara Navaei

DEN-12224 relocated the implementation of the software configuration check to a general location so HD and DG can use it

Options
    • -51
    • +51
    /NVDataMgmt.c
    • -7
    • +7
    /NVDataMgmtHDRecords.h
10:14 am

Dara Navaei

DEN-12224 combined check software configuration function into one function that covers both HD and DG

Options
    • -39
    • +30
    /NVDataMgmt.c
Friday 18 Mar 2022
4:55 pm

hnguyen  (deleted user)

Idle mode calls BOOL isAvgConductivityOutOfRange( void ){ return fillStatus.fillAvgConductivityOutOfRange; }

Idle mode calls
BOOL isAvgConductivityOutOfRange( void )

Unknown macro: { return fillStatus.fillAvgConductivityOutOfRange; }
4:04 pm

hnguyen  (deleted user)

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

Renamed setBottlesNeedPrimeFlag() to setThisFirstFillFlag()

4:02 pm

hnguyen  (deleted user)

This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c

This function is obsolete since the fillBottlesNeedPrimeFlag is replaced by isThisFirstFill flag in ModeFill.c

3:43 pm

hnguyen  (deleted user)

Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );

Removed isBadFill() function and used signal function isAvgConductivityOutOfRange( void );

2:17 pm

hnguyen  (deleted user)

Set result = DG_HANDLE_BAD_FILL_STATE_START;

Set result = DG_HANDLE_BAD_FILL_STATE_START;

2:01 pm

hnguyen  (deleted user)

Wait here for alarm is no longer active, then transition to fill mode.

Wait here for alarm is no longer active, then transition to fill mode.

1:31 pm

hnguyen  (deleted user)

Done.

Done.

1:30 pm

hnguyen  (deleted user)

Done.

Done.