fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Mar 2022
3:03 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /NVDataMgmt.c
    • -1
    • +1
    /NVDataMgmtDGRecords.h
2:46 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:35 pm

Dara Navaei

We should stop all the actuators prior to transitioning to standby.

We should stop all the actuators prior to transitioning to standby.

2:22 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:21 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:18 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:13 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:12 pm

hnguyen  (deleted user)

Ok

Ok

2:12 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:11 pm

hnguyen  (deleted user)

Those #define below will not be removed until they are added into the calibration records. #define ACID_NORMAL_CONDUCTIVITY 11645.05 #define BICARB_NORMAL_CONDUCTIVITY 13734.88

Those #define below will not be removed until they are added into the calibration records.
#define ACID_NORMAL_CONDUCTIVITY 11645.05
#define BICARB_NORMAL_CONDUCTIVITY 13734.88

2:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:08 pm

hnguyen  (deleted user)

Updated to BOOL const isConductTooLow = ( conductivity <= COND_SENSOR_CPI_MIN_VALUE ) ? TRUE : FALSE; BOOL const isConductTooHigh = ( conductivity >= COND_SENSOR_CPI_WARNING_HIGH ) ? TRUE : FALSE ;

Updated to
BOOL const isConductTooLow = ( conductivity <= COND_SENSOR_CPI_MIN_VALUE ) ? TRUE : FALSE;

BOOL const isConductTooHigh = ( conductivity >= COND_SENSOR_CPI_WARNING_HIGH ) ? TRUE : FALSE ;

2:07 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

2:04 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:04 pm

Michael Garthwaite

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

2:02 pm

Dara Navaei

Per our coding style, please use ternary for these two booleans: isConductTooLow = ( conductivity <= COND_SENSOR... ? TRUE : FALSE )

Per our coding style, please use ternary for these two booleans: isConductTooLow = ( conductivity <= COND_SENSOR... ? TRUE : FALSE )

2:00 pm

Dara Navaei

Done.

Done.

2:00 pm

Dara Navaei

DEN-12215 addressed the code reivew comment

Options
    • -1
    • +1
    /NVDataMgmtDGRecords.h
1:45 pm

Dara Navaei

Please do not remove the #defines until the calibration records are updated.

Please do not remove the #defines until the calibration records are updated.

1:41 pm

Dara Navaei

Add doxygen comment.

Add doxygen comment.

1:39 pm

Dara Navaei

Add doxygen comment.

Add doxygen comment.

1:14 pm

Sean Nash

It looks like staging branch has things the way it was too.

It looks like staging branch has things the way it was too.

1:13 pm

hnguyen  (deleted user)

Added internal signal flag handleBadFillFlag

Added internal signal flag handleBadFillFlag

1:04 pm

Sean Nash

Should be since last service (not last treatment).

Should be since last service (not last treatment).

11:00 am

hnguyen  (deleted user)

Removed flush lines

Removed flush lines

11:00 am

hnguyen  (deleted user)

The fillStatus.fillEmptyAcidBottleDetected is set to TRUE to signal drain mode that empty bottle is detected This flag is checked at the end of the drain mode.

The fillStatus.fillEmptyAcidBottleDetected is set to TRUE to signal drain mode that empty bottle is detected
This flag is checked at the end of the drain mode.

10:53 am

hnguyen  (deleted user)

Corrected Initialized in case DG_GEN_IDLE_MODE_STATE_START: // Execute current generation idle state switch ( genIdleState ) { case DG_GEN_IDLE_MODE_STATE_START: badFillState = DG_HANDLE_BAD_FILL_...

Corrected
Initialized in case DG_GEN_IDLE_MODE_STATE_START:

// Execute current generation idle state
switch ( genIdleState )
{
case DG_GEN_IDLE_MODE_STATE_START:
badFillState = DG_HANDLE_BAD_FILL_STATE_START;
genIdleState = handleIdleStartState();
break;

10:43 am

dcox  (deleted user)

This was part of the merge from staging branch.

This was part of the merge from staging branch.