fwcommon

Clone Tools

Stats

Commits this week: 2
Total Committers: 13
Last Commit: 04 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 20 May 2022
3:48 pm

Sean Nash

Remove blank line.

Remove blank line.

3:48 pm

Sean Nash

Remove blank line.

Remove blank line.

3:43 pm

Sean Nash

Remove blank line.

Remove blank line.

3:41 pm

Sean Nash

Why isn't this command allowed for release version?

Why isn't this command allowed for release version?

3:41 pm

Sean Nash

Is this zero temporary? If so, add TODO.

Is this zero temporary? If so, add TODO.

3:02 pm

Sean Nash

I don't think we should exit normal mode in TreatmentStop sub-mode.

I don't think we should exit normal mode in TreatmentStop sub-mode.

3:01 pm

Sean Nash

Should we exit blood leak normal mode in here somewhere?

Should we exit blood leak normal mode in here somewhere?

2:45 pm

Sean Nash

Ask Behrouz if UI is still looking for this. Remove if not.

Ask Behrouz if UI is still looking for this. Remove if not.

2:06 pm

Sean Nash

Remove extra blank line. And why is there any blank line here?

Remove extra blank line. And why is there any blank line here?

2:05 pm

Sean Nash

Seems like we're setting a start time offset here, not a time stamp.

Seems like we're setting a start time offset here, not a time stamp.

2:04 pm

Sean Nash

Should be rpmAlarmStartTime

Should be rpmAlarmStartTime

2:00 pm

Sean Nash

Did we want this offset to revert to zero here or should Dialin have to do a reset?

Did we want this offset to revert to zero here or should Dialin have to do a reset?

1:57 pm

Sean Nash

I don't think this results in an elapsed time. It's just a different start time. The calcTimeSince below gives you the elapsed time.

I don't think this results in an elapsed time. It's just a different start time. The calcTimeSince below gives you the elapsed time.

Wednesday 18 May 2022
4:53 pm

Sean Nash

Should we set this flag only if we are in normal state?

Should we set this flag only if we are in normal state?

4:50 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

4:45 pm

Sean Nash

Should this be set to FALSE?

Should this be set to FALSE?

4:40 pm

Sean Nash

"reset" should be "rest" I think.

"reset" should be "rest" I think.

4:35 pm

Sean Nash

Agree. Dara, make these look something like "C_CALIBRATION_CMD".

Agree. Dara, make these look something like "C_CALIBRATION_CMD".

4:03 pm

Sean Nash

We will want to tighten these eventually.

We will want to tighten these eventually.

3:58 pm

Sean Nash

It is used on lines 302, 1172, 1795, 1875.

It is used on lines 302, 1172, 1795, 1875.

3:46 pm

Sean Nash

We want release s/w to be fully enabled with no special test code. SW configs are structured such that a disabled config is what is wanted for release s/w and so forcing all s/w configs to be disab...

We want release s/w to be fully enabled with no special test code. SW configs are structured such that a disabled config is what is wanted for release s/w and so forcing all s/w configs to be disabled in a release build ensures we don't accidentally leave a config in the wrong state.

3:33 pm

Sean Nash

NoDRcr should be FALSE.

NoDRcr should be FALSE.

3:30 pm

Sean Nash

NoBRcr should be TRUE and NoDRcr should be FALSE.

NoBRcr should be TRUE and NoDRcr should be FALSE.

3:13 pm

Sean Nash

Do we need this state?

Do we need this state?

3:12 pm

Sean Nash

For all DG faults, the NoRes should be TRUE, but the NoRin and NoEnd should be FALSE so user can perform rinseback and/or end treatment.

For all DG faults, the NoRes should be TRUE, but the NoRin and NoEnd should be FALSE so user can perform rinseback and/or end treatment.

Thursday 12 May 2022
2:49 pm

dcox  (deleted user)

One letter enums could be more descriptive with their names.

One letter enums could be more descriptive with their names.

2:41 pm

dcox  (deleted user)

Why no SW Config in Release?

Why no SW Config in Release?

Wednesday 11 May 2022
1:13 pm

Dara Navaei

1:13 pm

Dara Navaei

Friday 15 Apr 2022
4:26 pm

Sean Nash

Dara removed this line of code after lab test w/o this change could not replicate the bug.

Dara removed this line of code after lab test w/o this change could not replicate the bug.