fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-12931: Moved safety line pull for integrity check.

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

Removed blank line

Removed blank line

Will add back in.

Will add back in.

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.

Can we remove this code now?

Can we remove this code now?

Why is this commented out?

Why is this commented out?

Can we just remove this code now?

Can we just remove this code now?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Why is this alarm commented out?

Why is this alarm commented out?

I think we need two separate minimums here. 1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name. 2. used by UVReactors.c should be 0.3 and private (declared in UVRea...

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

Remove extra blank line.

Remove extra blank line.

Why did this change? I think it's needed for doxygen.

Why did this change? I think it's needed for doxygen.

DG-DEN-12974_Miscellaneous Flush Issues BB
DG-DEN-12974_Miscellaneous Flush Issues BB
Merge branch 'DEN-12931-dg_hd_dev-hd_dg_dvt-update' into develop

DEN-12931 added the HD RTC low battery alarm

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Removed the message.

Removed the message.

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), b...

We got recommendation to monitor arterial pressure even when not dialyzing if patient is still connected (so all other treatment mode states other than dialysis when not delivering saline bolus), but didn't want to apply the user provided limits - just want to monitor for max pressure situation.

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment paramet...

Im assuming that this if statement covers sub modes like Saline and Blood Prime. How do we know during blood prime, specifically, that we would not be dealing with an edge case in treatment parameters for the patient (Ex: -300 mmHg to -270 mmHg) and triggering a false positive alarm?

Note: I dont know actual patient bp values but these are currently acceptable treatment parameters for arterial pressure limits.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.