fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Jul 2022
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.

Tuesday 12 Jul 2022
3:20 pm

Sean Nash

indent of cases looks too small.

indent of cases looks too small.

3:20 pm

Sean Nash

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?

3:17 pm

Sean Nash

Update input/outputs throughout.

Update input/outputs throughout.

3:13 pm

Sean Nash

Add blank line before return.

Add blank line before return.

Thursday 07 Jul 2022
1:28 pm

Michael Garthwaite

Do we want to keep this debug & sprintf?

Do we want to keep this debug & sprintf?

7:04 am

Dara Navaei

HD-DEN-12931_DG HD Dev HD DG Dvt Update
HD-DEN-12931_DG HD Dev HD DG Dvt Update
Wednesday 06 Jul 2022
10:54 am

wbracken  (deleted user)

That would also require a change to the requirements.

That would also require a change to the requirements.

Tuesday 28 Jun 2022
11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:41 am

wbracken  (deleted user)

Removed blank line

Removed blank line

10:38 am

wbracken  (deleted user)

Will add back in.

Will add back in.

9:01 am

Sean Nash

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.

8:59 am

Sean Nash

Can we remove this code now?

Can we remove this code now?

8:59 am

Sean Nash

Why is this commented out?

Why is this commented out?

8:58 am

Sean Nash

Can we just remove this code now?

Can we just remove this code now?

8:58 am

Sean Nash

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

Does this function activate alarm too? Why needed if line above activates alarm already? Why commented out?

8:56 am

Sean Nash

Why is this alarm commented out?

Why is this alarm commented out?

8:55 am

Sean Nash

I think we need two separate minimums here. 1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name. 2. used by UVReactors.c should be 0.3 and private (declared in UVRea...

I think we need two separate minimums here.
1. used by ROPump.c should be 0.2 and private (declared in ROPump.c) with this name.
2. used by UVReactors.c should be 0.3 and private (declared in UVReactors.c) with a different name like MIN_RO_FLOW_FOR_UV_LPM.

8:51 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:49 am

Sean Nash

Why did this change? I think it's needed for doxygen.

Why did this change? I think it's needed for doxygen.