fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 Jul 2022
8:28 am

Sean Nash

Why removed?

Why removed?

8:27 am

Sean Nash

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

Thursday 21 Jul 2022
9:03 pm

Sean Nash

F has been added.

F has been added.

9:01 pm

Sean Nash

No. Code removed.

No. Code removed.

8:58 pm

Sean Nash

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

8:52 pm

Sean Nash

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

8:50 pm

Sean Nash

Remove blank line.

Remove blank line.

8:49 pm

Sean Nash

Can we remove this now?

Can we remove this now?

Monday 18 Jul 2022
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.

Tuesday 12 Jul 2022
3:20 pm

Sean Nash

indent of cases looks too small.

indent of cases looks too small.

3:20 pm

Sean Nash

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?

3:17 pm

Sean Nash

Update input/outputs throughout.

Update input/outputs throughout.

3:13 pm

Sean Nash

Add blank line before return.

Add blank line before return.

Thursday 07 Jul 2022
1:28 pm

Michael Garthwaite

Do we want to keep this debug & sprintf?

Do we want to keep this debug & sprintf?

7:04 am

Dara Navaei

HD-DEN-12931_DG HD Dev HD DG Dvt Update
HD-DEN-12931_DG HD Dev HD DG Dvt Update
Wednesday 06 Jul 2022
10:54 am

wbracken  (deleted user)

That would also require a change to the requirements.

That would also require a change to the requirements.

Tuesday 28 Jun 2022
11:01 am

wbracken  (deleted user)

Seems like isADCValid should be returned.

Seems like isADCValid should be returned.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

11:00 am

Dara Navaei

This will be addressed in DEN-12931.

This will be addressed in DEN-12931.

10:41 am

wbracken  (deleted user)

Removed blank line

Removed blank line

10:38 am

wbracken  (deleted user)

Will add back in.

Will add back in.

9:01 am

Sean Nash

Should we return isADCValid? Pick one, remove the other.

Should we return isADCValid? Pick one, remove the other.