fwcommon

Clone Tools

Stats

Commits this week: 2
Total Committers: 13
Last Commit: 04 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Aug 2022
11:12 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:11 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:11 am

Sean Nash

Add resetStateTimer @param.

Add resetStateTimer @param.

11:07 am

Sean Nash

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

Why commented out? Remove if no longer needed. If coming back, use explicit condition ( TRUE == resetStateTimer ).

11:07 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

11:06 am

Sean Nash

Add resetStateTimer @param.

Add resetStateTimer @param.

11:06 am

Sean Nash

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

I don't see resetStateTimer being used (unless commented out code is coming back). Also, it is not in function header.

11:04 am

Sean Nash

Why commented out? Remove if no longer needed.

Why commented out? Remove if no longer needed.

11:03 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:02 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

11:01 am

Sean Nash

Separate assignments or at least put all in same line.

Separate assignments or at least put all in same line.

10:58 am

Sean Nash

Use explicit condition ( TRUE == resetStateTimer ).

Use explicit condition ( TRUE == resetStateTimer ).

10:56 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

10:55 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

10:55 am

Sean Nash

This looks like it allows flows > maximum now. What is the intent here?

This looks like it allows flows > maximum now. What is the intent here?

Friday 22 Jul 2022
8:28 am

Sean Nash

Why removed?

Why removed?

8:27 am

Sean Nash

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

Thursday 21 Jul 2022
9:03 pm

Sean Nash

F has been added.

F has been added.

9:01 pm

Sean Nash

No. Code removed.

No. Code removed.

8:58 pm

Sean Nash

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

8:52 pm

Sean Nash

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

8:50 pm

Sean Nash

Remove blank line.

Remove blank line.

8:49 pm

Sean Nash

Can we remove this now?

Can we remove this now?

Monday 18 Jul 2022
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.