fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 16 Sep 2022
11:08 am

Sean Nash

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 t...

Probably a good idea for consistency, but not necessary. Where we need to add the 'F' suffix to floating point literals is when the literal will not be typed. Here, we are assigning 0.0 to an F32 typed variable so it will be typed properly. A #define may or may not be typed depending on how it's used. If it's used in a mathematical expression, the compiler will make it max precision (double) if we don't explicitly add the 'F' suffix and that can cause some problems with the precision in the math.

10:31 am

Sean Nash

Remove blank line.

Remove blank line.

Monday 12 Sep 2022
4:24 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:24 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:23 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:23 pm

dcox  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:04 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

4:03 pm

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

12:21 pm

dcox  (deleted user)

Use 0.0F

Use 0.0F

12:17 pm

dcox  (deleted user)

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Sensor misspelled (Sesnor). Change name to execFlowSensorMonitor.

Thursday 08 Sep 2022
5:13 pm

Michael Garthwaite

Wednesday 31 Aug 2022
4:22 pm

wbracken  (deleted user)

Line 1902 is the same check but reverses the order.

Line 1902 is the same check but reverses the order.

2:42 pm

Dara Navaei

This code is un-commented.

This code is un-commented.

2:41 pm

Dara Navaei

Done.

Done.

2:39 pm

Dara Navaei

In in DEN-13834.

In in DEN-13834.

2:38 pm

Dara Navaei

Done.

Done.

2:37 pm

Dara Navaei

Added TODO to un-comment this line of code.

Added TODO to un-comment this line of code.

2:35 pm

Dara Navaei

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

"FAPI_CHECK_FSM_READY_BUSY" is a macro.

2:33 pm

Dara Navaei

Done.

Done.

Tuesday 30 Aug 2022
6:04 pm

Dara Navaei

Done.

Done.

Monday 29 Aug 2022
4:38 pm

wbracken  (deleted user)

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the sema...

What is the value of SEMAPHORE_IN_USE_TIMEOUT_MS? The timeout appears to only be check when getSemaphore is called. Seems like you could acquire the semaphore and the process that acquired the semaphore could hold onto it for a time much longer than SEMAPHORE_IN_USE_TIMEOUT.

4:31 pm

wbracken  (deleted user)

Should this function handle invalid hex characters?

Should this function handle invalid hex characters?

3:57 pm

wbracken  (deleted user)

Set "status" to FALSE.

Set "status" to FALSE.

3:51 pm

wbracken  (deleted user)

Should this be removed?

Should this be removed?

3:47 pm

wbracken  (deleted user)

Should variables in if be reversed?

Should variables in if be reversed?

3:42 pm

wbracken  (deleted user)

Should this be in or not?

Should this be in or not?

2:56 pm

wbracken  (deleted user)

Some values have "U"?

Some values have "U"?

2:49 pm

wbracken  (deleted user)

Are we moving away from initializing via definition?

Are we moving away from initializing via definition?

Friday 26 Aug 2022
4:07 pm

wbracken  (deleted user)

Remove comment.

Remove comment.

1:40 pm

dcox  (deleted user)

When will it be uncommented?

When will it be uncommented?