fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 14 Oct 2022
1:42 pm

Dara Navaei

Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' into develop

Options
    • -1
    • +39
    /Common.h
    • -0
    • +3
    /NVDataMgmt.c
12:09 pm

dcox  (deleted user)

Put define on left of comparison. DG_MODE_HEAT != dgOp.

Put define on left of comparison. DG_MODE_HEAT != dgOp.

12:06 pm

dcox  (deleted user)

Should a status of FALSE be set here since the input string is not a valid number?

Should a status of FALSE be set here since the input string is not a valid number?

11:36 am

dcox  (deleted user)

Fixed.

Fixed.

11:32 am

Sean Nash

Removed again?

Removed again?

11:30 am

Sean Nash

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

11:30 am

Sean Nash

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

11:30 am

Sean Nash

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

11:28 am

Sean Nash

Space before end )

Space before end )

11:27 am

Sean Nash

Can we uncomment this now?

Can we uncomment this now?

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:01 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:00 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:57 am

Michael Garthwaite

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

Dara Navaei

This is in fwcommon so it has to be able to cover both stacks.

This is in fwcommon so it has to be able to cover both stacks.

10:11 am

Dara Navaei

Disabled the #define.

Disabled the #define.

10:10 am

Dara Navaei

Done.

Done.

9:48 am

Dara Navaei

DEN-13834 added more comments

Options
    • -1
    • +2
    /Utilities.c
9:44 am

Dara Navaei

Done.

Done.

9:36 am

Dara Navaei

This was changed to be consistent with the rest of the FAPI if statements.

This was changed to be consistent with the rest of the FAPI if statements.

9:34 am

Dara Navaei

Done.

Done.

9:34 am

Dara Navaei

DEN-13834 addressed the code review comments

Options
    • -1
    • +39
    /Common.h
    • -0
    • +3
    /NVDataMgmt.c
    • -25
    • +57
    /Utilities.c
    • -1
    • +1
    /Utilities.h
Thursday 13 Oct 2022
11:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:58 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:57 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:56 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:54 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:53 pm

Sean Nash

Still below operation modes exec.

Still below operation modes exec.