fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-13834-dg_hd_dev-hd_dg_dvt-update-part-3' into develop

Put define on left of comparison. DG_MODE_HEAT != dgOp.

Put define on left of comparison. DG_MODE_HEAT != dgOp.

Should a status of FALSE be set here since the input string is not a valid number?

Should a status of FALSE be set here since the input string is not a valid number?

Fixed.

Fixed.

Removed again?

Removed again?

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

0.0F (pwm) param not in function - remove.

Space before end )

Space before end )

Can we uncomment this now?

Can we uncomment this now?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This is in fwcommon so it has to be able to cover both stacks.

This is in fwcommon so it has to be able to cover both stacks.

Disabled the #define.

Disabled the #define.

Done.

Done.

DEN-13834 added more comments

Done.

Done.

This was changed to be consistent with the rest of the FAPI if statements.

This was changed to be consistent with the rest of the FAPI if statements.

Done.

Done.

DEN-13834 addressed the code review comments

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Still below operation modes exec.

Still below operation modes exec.