fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 09 Nov 2022
1:13 pm

Dara Navaei

Done

Done

1:12 pm

Dara Navaei

Done.

Done.

1:11 pm

Dara Navaei

Done.

Done.

8:44 am

Sean Nash

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

8:41 am

Sean Nash

Doesn't this command take a pointer to a structure now?

Doesn't this command take a pointer to a structure now?

Monday 07 Nov 2022
11:27 am

Dara Navaei

This is here so both stacks can use it.

This is here so both stacks can use it.

11:27 am

Dara Navaei

Done.

Done.

10:44 am

Sean Nash

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:42 am

Sean Nash

Remove blank line.

Remove blank line.

10:41 am

Sean Nash

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

10:40 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:40 am

Sean Nash

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

10:39 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:21 am

wbracken  (deleted user)

Looks like blank line is still there.

Looks like blank line is still there.

9:37 am

Dara Navaei

Done.

Done.

9:33 am

Dara Navaei

Done.

Done.

Thursday 03 Nov 2022
10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:23 am

wbracken  (deleted user)

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

10:20 am

wbracken  (deleted user)

Update function header.

Update function header.

10:17 am

wbracken  (deleted user)

Remove blank line

Remove blank line

9:52 am

Dara Navaei

Done.

Done.

9:51 am

Dara Navaei

This function should stay commented. I have a TODO task for this.

This function should stay commented. I have a TODO task for this.

9:50 am

Dara Navaei

Done.

Done.

9:49 am

Dara Navaei

No these should be TRUE.

No these should be TRUE.

Friday 28 Oct 2022
3:13 pm

Michael Garthwaite

3:13 pm

Sean Nash

hasReg1Failed is initialized to FALSE. Should we be setting to TRUE in these ifs? Or should the initialize be setting to TRUE?

hasReg1Failed is initialized to FALSE. Should we be setting to TRUE in these ifs? Or should the initialize be setting to TRUE?

3:09 pm

Sean Nash

This revision also applies to UI.

This revision also applies to UI.

3:07 pm

Sean Nash