fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Done

Done

Done.

Done.

Done.

Done.

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Still doesn't belong here. We can either have a new shared FPGA header file or we can have two of these - one for each sub-system (similar to how we have two FPGA.c/.h files).

Doesn't this command take a pointer to a structure now?

Doesn't this command take a pointer to a structure now?

This is here so both stacks can use it.

This is here so both stacks can use it.

Done.

Done.

Why is this in utilities module? Doesn't it make more sense in fpga module?

Why is this in utilities module? Doesn't it make more sense in fpga module?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Remove blank line.

Remove blank line.

None of these structures appear to require packing - all 32-bit fields.

None of these structures appear to require packing - all 32-bit fields.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

If this message is for DG CPLD only, should change enum to "MSG_ID_DG_CPLD_...".

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Looks like blank line is still there.

Looks like blank line is still there.

Done.

Done.

Done.

Done.

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

RESOLVED IN CODE WALKTHROUGH

Update function header.

Update function header.

Remove blank line

Remove blank line

Done.

Done.

This function should stay commented. I have a TODO task for this.

This function should stay commented. I have a TODO task for this.

Done.

Done.

No these should be TRUE.

No these should be TRUE.

hasReg1Failed is initialized to FALSE. Should we be setting to TRUE in these ifs? Or should the initialize be setting to TRUE?

hasReg1Failed is initialized to FALSE. Should we be setting to TRUE in these ifs? Or should the initialize be setting to TRUE?

This revision also applies to UI.

This revision also applies to UI.