fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Jan 2023
3:08 pm

wbracken  (deleted user)

Seems like there are several variables missing.

Seems like there are several variables missing.

3:01 pm

Dara Navaei

DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
DG-DEN-14604_DG HD Dev HD DG Dvt Update Part 9
1:49 pm

Sean Nash

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

This looks strange. Why is TD2 temp usually 0.0, but read if using TPo?

1:43 pm

Sean Nash

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

Prefer doing this kind of thing with a loop iterating through the enum in case we add/remove a reservoir.

1:41 pm

Sean Nash

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

Does hasAlarmBeenTriggered need to be set here too? If not, need to clarify what that flag really means.

1:36 pm

Sean Nash

Need to be careful with these. These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override v...

Need to be careful with these.
These functions are currently resetting the POST functions to start at beginning, but also need to reset ANY variables that the POST functions use/set (not override variables though).
Also, since we are not re-initializing everything like a true reset does, we need to make sure that these modules are setup to restart or resume (whichever is more appropriate for the module) after POST completes if the module is in any way interrupted/deferred by POST or competing with POST for a resource/driver (e.g. RTC or NV-Data).

1:24 pm

Sean Nash

Variable should already be a BOOL.

Variable should already be a BOOL.

1:24 pm

Sean Nash

Set to TRUE here.

Set to TRUE here.

1:23 pm

Sean Nash

Initialize to FALSE.

Initialize to FALSE.

1:23 pm

Sean Nash

Rename to isDGFaultActive.

Rename to isDGFaultActive.

1:22 pm

Sean Nash

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

Name is too broad and comment is too specific. Should probably be a BOOL flag that indicates there is an active DG fault.

1:17 pm

Sean Nash

This alarm does not appear to be available. Correct description in last column (trigger condition).

This alarm does not appear to be available. Correct description in last column (trigger condition).

1:08 pm

Sean Nash

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

Do we need to re-queue these reads? We've already done it at real POST. And if we do need to queue them, why does queue have to be empty? Shouldn't we always queue them if they're needed?

Monday 16 Jan 2023
12:11 pm

wbracken  (deleted user)

Alignment

Alignment

10:55 am

jtaylor  (deleted user)

Alignment

Alignment

Wednesday 11 Jan 2023
5:01 pm

Dara Navaei

DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
DG-DEN-14559_DG HD Dev HD DG Dvt Update Part 8
Tuesday 03 Jan 2023
4:28 pm

Dara Navaei

4:18 pm

wbracken  (deleted user) and Sean Nash

Thursday 29 Dec 2022
11:23 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:22 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:10 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

11:10 am

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

11:09 am

jtaylor  (deleted user)

9:47 am

Sean Nash

For a release build, looks like we would do nothing and get stuck in this state.

For a release build, looks like we would do nothing and get stuck in this state.

9:45 am

Sean Nash

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Add doxygen comment for persistence. Try to capture thinking on why this is such a brief period.

Thursday 22 Dec 2022
1:35 pm

Michael Garthwaite

Fixed. Thanks!

Fixed. Thanks!

1:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:29 pm

Michael Garthwaite

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

The only time we would be adding more states is if we are no longer on HIGH/LOW control, like switching to PWM. That would be such a significant change that this would be reviewed.

1:27 pm

Sean Nash

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

Would rather you set a BOOL based on state and then pass the BOOL to persistent alarm function. I'm afraid we could add more states later and forget about this.

1:25 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.