fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-14999-alarm-table-updates' into develop

DEN-14999, DEN-15031 reused the start DG structure that already exists

DEN-14999, DEN-15031 updated the DG NV records with the acid and bicarb values

DEN-14646 Code cleanup

DEN-14999, DEN-15031 updated the NV data management to add the fill conductivity values.

I don't see it, but resolving anyway. RESOLVED in CODE WALKTHROUGH.

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

DEN-14999 added another condition in NV data management to make sure all the jobs in the queue are processed and the state machine is in idle state so even the last queue has been fully read

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

DEN-14646 Simplify checkFPGAPersistentAlarms

Corrected

Corrected

Merge branch 'DEN-14999-alarm-table-updates' into develop

DEN-14999 added a data structure for the DG start command

Merge branch 'staging' into DEN-14646-fpga-alarm-properties-and-timing-3

Merge branch 'staging' into develop

Can we rename variable to reflect it is a timer counter at least?

Can we rename variable to reflect it is a timer counter at least?

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

The variable that define is being compared to is valveStateMismatchCounter which is why I called it such.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Yes, and #define has "COUNT" in its name which was my point.

Yes, and #define has "COUNT" in its name which was my point.

DEN-14646 Remove accelerometer error count

Corrected

Corrected

Alarm is based on a counter. The #define corresponds to a 100ms time.

Alarm is based on a counter. The #define corresponds to a 100ms time.

Corrected

Corrected

Added DEBUG WARNING

Added DEBUG WARNING

DG-DEN-14999_Alarm Table Updates
DG-DEN-14999_Alarm Table Updates
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces