fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'staging' into DEN-15199-fw_dn_sprint_95-part-2

DEN-15199 addressed the code review comments

Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Temporarily commented out the new conductivity calibration record to not get the DG calibration record CRC failure

Please see changes.

Please see changes.

Done

Done

DEN-15199 work in progress, continued implementing the test configurations

This looks like 104.

This looks like 104.

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?

Add blank line before return statement.

Add blank line before return statement.

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

Merge branch 'DEN-14892-add-bootloader-to-existing-dg-firmware' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-14892-add-bootloader-to-existing-dg-firmware

Merge branch 'DEN-14892-add-bootloader-to-existing-dg-firmware' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-14892-add-bootloader-to-existing-dg-firmware

Is #if temporary?

Is #if temporary?

Are these #if temporary?

Are these #if temporary?

Looks like merge issues not resolved.

Looks like merge issues not resolved.

Is the merge correct?

Is the merge correct?

HD-DEN-14892_Add Bootloader TO Existing DG Firmware
HD-DEN-14892_Add Bootloader TO Existing DG Firmware
Merge branch 'DEN-15246-active-reservoir-empty-post-concentrate-alarm-recovery' into develop

DEN-15246 added a CD2 conductivity sensor calibration record for bicarb test

Merge branch 'staging' into DEN-14892-add-bootloader-to-existing-dg-firmware

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Remove extra blank line.

Remove extra blank line.

Update header.

Update header.