fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 08 May 2023
2:51 pm

Dara Navaei

Merge branch 'staging' into DEN-15199-fw_dn_sprint_95-part-2

Options
11:09 am

Dara Navaei

DEN-15199 addressed the code review comments

Options
    • -1
    • +0
    /TestSupport.c
    • -3
    • +3
    /TestSupport.h
9:06 am

Sean Nash

Is this needed? Why would a worn cartridge fail pressure test?

Is this needed? Why would a worn cartridge fail pressure test?

9:03 am

Sean Nash

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).

9:02 am

Sean Nash

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

I don't think a worn cartridge should fail here (should still be dry). I think only wet cartridge should be checked here.

8:58 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:52 am

Sean Nash

Recommend being more direct in naming: TEST_CONFIG_USE_WET_CARTRIDGE TEST_CONFIG_USE_WORN_CARTRIDGE

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

8:48 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 04 May 2023
3:21 pm

wbracken  (deleted user)

2:54 pm

Dara Navaei

Temporarily commented out the new conductivity calibration record to not get the DG calibration record CRC failure

Options
    • -1
    • +1
    /NVDataMgmtDGRecords.h
10:39 am

Dara Navaei

Please see changes.

Please see changes.

10:35 am

Dara Navaei

Done

Done

9:09 am

Dara Navaei

DEN-15199 work in progress, continued implementing the test configurations

Options
    • -3
    • +3
    /NVDataMgmtHDRecords.h
    • -0
    • +7
    /TestSupport.c
    • -0
    • +1
    /TestSupport.h
8:29 am

Sean Nash

This looks like 104.

This looks like 104.

8:28 am

Sean Nash

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?

8:24 am

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

8:23 am

Sean Nash

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

6:32 am

Dana Rich <drich@sunriselabs.com>

Merge branch 'DEN-14892-add-bootloader-to-existing-dg-firmware' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-14892-add-bootloader-to-existing-dg-firmware

Options
5:27 am

Dana Rich <drich@sunriselabs.com>

Merge branch 'DEN-14892-add-bootloader-to-existing-dg-firmware' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-14892-add-bootloader-to-existing-dg-firmware

Options
Wednesday 03 May 2023
3:20 pm

wbracken  (deleted user)

Is #if temporary?

Is #if temporary?

3:18 pm

wbracken  (deleted user)

Are these #if temporary?

Are these #if temporary?

3:15 pm

wbracken  (deleted user)

Looks like merge issues not resolved.

Looks like merge issues not resolved.

3:13 pm

wbracken  (deleted user)

Is the merge correct?

Is the merge correct?

2:02 pm

Dara Navaei

HD-DEN-14892_Add Bootloader TO Existing DG Firmware
HD-DEN-14892_Add Bootloader TO Existing DG Firmware
1:32 pm

Dara Navaei

Merge branch 'DEN-15246-active-reservoir-empty-post-concentrate-alarm-recovery' into develop

Options
12:44 pm

Dara Navaei

DEN-15246 added a CD2 conductivity sensor calibration record for bicarb test

Options
    • -2
    • +3
    /NVDataMgmtDGRecords.h
10:42 am

Dana Rich <drich@sunriselabs.com>

Merge branch 'staging' into DEN-14892-add-bootloader-to-existing-dg-firmware

Options
Tuesday 02 May 2023
5:06 pm

Sean Nash

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

Let's discuss how test config is being used in this case. It seems like it's all over the place to me.

4:52 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:21 pm

wbracken  (deleted user)

Update header.

Update header.