fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 May 2023
11:02 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15104-hd-fpga-communications

# Conflicts:

# Utilities.h

Options
    • -43
    • +45
    /Utilities.h
11:01 am

Sean Nash

Use enums instead of literals.

Use enums instead of literals.

11:01 am

Sean Nash

Don't we have an enum for these values?

Don't we have an enum for these values?

10:58 am

Sean Nash

Is there more to be done here (TODO)?

Is there more to be done here (TODO)?

10:56 am

Sean Nash

I think these variable declarations should stay here. Why move to function?

I think these variable declarations should stay here. Why move to function?

10:55 am

Sean Nash

This is HD f/w. Why are you looking at DG mode?

This is HD f/w. Why are you looking at DG mode?

10:53 am

Sean Nash

Why aren't these declared at top of file and initialized in init function like everything else.

Why aren't these declared at top of file and initialized in init function like everything else.

10:48 am

Bill Bracken <bill@criticalsoftwaresolutions.com>

Merge branch 'staging' into DEN-15104-hd-fpga-communications

Options
    • -2
    • +0
    /Utilities.h
10:35 am

Sean Nash

Why is this in two places? And why set every 10ms when it appears to be constant?

Why is this in two places? And why set every 10ms when it appears to be constant?

10:34 am

Sean Nash

This doesn't seem to ever change. Why not just initialize this value once on reset?

This doesn't seem to ever change. Why not just initialize this value once on reset?

10:33 am

Sean Nash

Make U32.

Make U32.

10:16 am

Dara Navaei

Merge branch 'staging' into DEN-15274-hd_dg_test_configuration_setup

Options
10:13 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /NVDataMgmt.c
    • -1
    • +1
    /NVDataMgmtDGRecords.h
9:50 am

Dara Navaei

9:47 am

Dara Navaei

Merge branch 'staging' into DEN-15246-active-reservoir-empty-post-concentrate-alarm-recovery

Options
9:29 am

Sean Nash

Declarations before code.

Declarations before code.

8:59 am

wbracken  (deleted user) and Sean Nash

8:49 am

Dara Navaei

Merge branch 'DEN-15246-active-reservoir-empty-post-concentrate-alarm-recovery' into develop

Options
    • -1
    • +1
    /NVDataMgmt.c
    • -1
    • +0
    /NVDataMgmtDGRecords.h
8:43 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /Utilities.h
8:42 am

Michael Garthwaite

Merge branch 'DEN-15196-Alarm-98-rework' into staging

Options
8:42 am

Michael Garthwaite

Merge branch 'staging' into DEN-15196-Alarm-98-rework

Options
    • -3
    • +4
    /Utilities.h
8:40 am

Michael Garthwaite

8:38 am

Sean Nash

Should be != TRUE?

Should be != TRUE?

8:35 am

Sean Nash

loadcells[] is an output in this function.

loadcells[] is an output in this function.

8:29 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 11 May 2023
9:30 pm

Dara Navaei

Done

Done

7:50 pm

Sean Nash

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

Keep going. Now 95 is wrong. Need comments to align with actual values throughout.

5:33 pm

Dara Navaei

Done

Done

5:21 pm

Sean Nash

Then the one above with 100 comment is wrong.

Then the one above with 100 comment is wrong.

5:19 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.