fwcommon

Clone Tools

Stats

Commits this week: 4
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 4

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 14 May 2023
12:46 pm

Dara Navaei

DEN-15274 added a new DG/HD test configuration

Options
    • -1
    • +1
    /TestSupport.c
    • -0
    • +2
    /TestSupport.h
11:28 am

wbracken  (deleted user)

No longer needed.

No longer needed.

11:23 am

wbracken  (deleted user)

Extra blank line.

Extra blank line.

11:22 am

wbracken  (deleted user)

Comment for function.

Comment for function.

10:03 am

Dara Navaei

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-15274-hd_dg_test_configuration_setup

Options
10:03 am

Dara Navaei

DEN-15274 updated the bicarb conductivity value for testing

Options
    • -1
    • +1
    /NVDataMgmt.c
Saturday 13 May 2023
10:01 pm

Dara Navaei

DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
11:30 am

wbracken  (deleted user)

Are these TODOs going to be removed?

Are these TODOs going to be removed?

Friday 12 May 2023
5:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:29 pm

Sean Nash

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

5:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:28 pm

Sean Nash

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

5:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

Now it's gone. No longer needed?

Now it's gone. No longer needed?

2:02 pm

Dara Navaei

DEN-15274 added HD test configuration commands

Options
    • -2
    • +2
    /NVDataMgmtHDRecords.h
    • -0
    • +2
    /TestSupport.h
1:48 pm

wbracken  (deleted user)

Removed

Removed

1:47 pm

wbracken  (deleted user)

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the...

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

1:39 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:33 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:31 pm

wbracken  (deleted user)

Corrected

Corrected

1:21 pm

wbracken  (deleted user)

Removed

Removed

1:20 pm

wbracken  (deleted user)

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

1:16 pm

wbracken  (deleted user)

They were used when FE OE generated software fault. Removed.

They were used when FE OE generated software fault. Removed.