fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15274 added a new DG/HD test configuration

No longer needed.

No longer needed.

Extra blank line.

Extra blank line.

Comment for function.

Comment for function.

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-15274-hd_dg_test_configuration_setup

DEN-15274 updated the bicarb conductivity value for testing

DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
Are these TODOs going to be removed?

Are these TODOs going to be removed?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Now it's gone. No longer needed?

Now it's gone. No longer needed?

DEN-15274 added HD test configuration commands

Removed

Removed

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the...

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

Corrected

Corrected

Removed

Removed

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

They were used when FE OE generated software fault. Removed.

They were used when FE OE generated software fault. Removed.