fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-15274 addressed a code review comment

Fixed it.

Fixed it.

Disagree with comment change.

Disagree with comment change.

Let's put test config conditions last when mixing with normal conditions (both ifs).

Let's put test config conditions last when mixing with normal conditions (both ifs).

DEN-15336 Add FE/OE to FPGA communications.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done

Done

Done

Done

Moved to here from function.

Moved to here from function.

DEN-15274 added a new DG/HD test configuration

No longer needed.

No longer needed.

Extra blank line.

Extra blank line.

Comment for function.

Comment for function.

Merge branch 'DEN-15274-hd_dg_test_configuration_setup' of ssh://devapps.diality.us:7999/comm/fwcommon into DEN-15274-hd_dg_test_configuration_setup

DEN-15274 updated the bicarb conductivity value for testing

DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
DG-DEN-15336_FW Add Framing Error FE And Overrun Error OE TO DG TO Fpga Communications
Are these TODOs going to be removed?

Are these TODOs going to be removed?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.