fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge branch 'DEN-15363-fw-handle-bld-sensor-communication-errors' into staging

Done

Done

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

Remove "handle" from this function name. It should start with "send". And why does this message have a payload. Message itself infers ready.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This function will be overhauled.

This function will be overhauled.

Done

Done

Done

Done

Done

Done

Done

Done

Done

Done

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

This function is only to set the actuators. If the incorrect message status is selected the collect sample function will trigger the software fault.

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

This is the lower level function to set the actuators. If the state is incorrect the state machine in the exec function will trigger the software fault.

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

Changed to TRUE. Yes this message is only dispatched when DG has finished dispensing and is sending HD a message that it is ready to process another dispense or cancel command.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Merge branch 'DEN-15477-add-windowed-timer-to-drain-pump-encoder-error' into staging

Merge branch 'DEN-15477-add-windowed-timer-to-drain-pump-encoder-error' into develop

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

We're always ready? Why does UI need to ask if DG is ready if always ready? Replace "1" with "TRUE".

We're always ready? Why does UI need to ask if DG is ready if always ready?
Replace "1" with "TRUE".

Should this be a s/w fault?

Should this be a s/w fault?

Should default be separate from DISPENSING? And should default have a s/w fault?

Should default be separate from DISPENSING? And should default have a s/w fault?

Comment alignment.

Comment alignment.

Cycle is mis-spelled.

Cycle is mis-spelled.

The check against nearly zero is pointless since we're looking for > 10 mL/min now. Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking agai...

The check against nearly zero is pointless since we're looking for > 10 mL/min now.
Is cpTargetSpeed always positive (even when in reverse)? If not, should absolute value speed before checking against low speed threshold.

Not really "off". Should be applied when going slowly (<10 mL/min).

Not really "off". Should be applied when going slowly (<10 mL/min).

Merge branch 'staging' into DEN-15363-fw-handle-bld-sensor-communication-errors

Merge branch 'staging' into DEN-15477-add-windowed-timer-to-drain-pump-encoder-error