fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 26 Jun 2023
3:49 pm

Dara Navaei

Merge branch 'DEN-15660-test_configuration_treatment_recovery' into develop

Options
2:34 pm

Dara Navaei

DEN-15660 updated the HD NV software configurations

Options
    • -2
    • +2
    /NVDataMgmtHDRecords.h
2:10 pm

wbracken  (deleted user)

Add nelsonSupport

Add nelsonSupport

2:09 pm

wbracken  (deleted user)

Update header.

Update header.

2:08 pm

wbracken  (deleted user)

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

2:04 pm

wbracken  (deleted user)

Add stateTrialCounter

Add stateTrialCounter

2:04 pm

wbracken  (deleted user)

Add nelsonSupport, stateTrialCounter to header.

Add nelsonSupport, stateTrialCounter to header.

1:01 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /Accel.c
Friday 23 Jun 2023
4:33 pm

dcox  (deleted user)

4:17 pm

Darren Cox <darren_m@cox.net>

Merge branch 'DEN-15272-fw-alarm-9-dg-fault-acc-vector-triggers-on-startup' into develop

Options
    • -12
    • +39
    /Accel.c
10:46 am

wbracken  (deleted user) and Sean Nash

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Thursday 22 Jun 2023
12:18 pm

dcox  (deleted user)

I simplified it. Now if fails, test ends. If passed ( < 3 errors), PASS result is set on exit with Complete state.

I simplified it. Now if fails, test ends. If passed ( < 3 errors), PASS result is set on exit with Complete state.

12:12 pm

Darren Cox <darren_m@cox.net>

DEN-15272 Updated for code review comments #3.

Options
    • -10
    • +9
    /Accel.c
11:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:45 am

Sean Nash

I think I understand how this works now. Kind of confusing how this is done and strange to see passed set here when it just failed. If I understand correctly, test must fail 3 out of the 5 tests to...

I think I understand how this works now. Kind of confusing how this is done and strange to see passed set here when it just failed.
If I understand correctly, test must fail 3 out of the 5 tests to fail the whole test - otherwise it passes?

11:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

dcox  (deleted user)

Value is overridden below if the test is repeated. If it is the last time through test, it needs to be set here as Pass/Fail based on Fail counter.

Value is overridden below if the test is repeated. If it is the last time through test, it needs to be set here as Pass/Fail based on Fail counter.

10:35 am

Darren Cox <darren_m@cox.net>

DEN-15272 Updated for code review comments #2.

Options
    • -2
    • +2
    /Accel.c
10:30 am

dcox  (deleted user)

Removed.

Removed.

10:29 am

dcox  (deleted user)

Moved declarations to top of file.

Moved declarations to top of file.

10:29 am

dcox  (deleted user)

Moved to function header.

Moved to function header.

10:28 am

dcox  (deleted user)

Fixed.

Fixed.

10:26 am

Darren Cox <darren_m@cox.net>

DEN-15272 Updated for code review comments #1.

Options
    • -13
    • +10
    /Accel.c
8:39 am

Sean Nash

state is already in progress - no need to reassign it here. result is already in progress as well.

state is already in progress - no need to reassign it here.
result is already in progress as well.

8:37 am

Sean Nash

Prefer not to have local statics. Move to top of file.

Prefer not to have local statics. Move to top of file.

8:37 am

Sean Nash

Remove comment. Maybe move part about bumping to brief above.

Remove comment. Maybe move part about bumping to brief above.

8:34 am

Sean Nash

Why are we passing test here? I think if you pass here, you will not return and retry. Should leave result as in progress to keep the test going.

Why are we passing test here? I think if you pass here, you will not return and retry. Should leave result as in progress to keep the test going.