fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Checking the accuracy of the RTC to cpu ms time was removed. The accuracy of the cpu ms time is checked against the FPGA ms time. The RTC time is verified against the FPGA ms time.

Checking the accuracy of the RTC to cpu ms time was removed. The accuracy of the cpu ms time is checked against the FPGA ms time. The RTC time is verified against the FPGA ms time.

HD-DEN-15773_FW Remove Rtc Cpu Time Firmware From Post
HD-DEN-15773_FW Remove Rtc Cpu Time Firmware From Post
Add nelsonSupport

Add nelsonSupport

Update header.

Update header.

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

Update header: rsrvr2Status, isRsrveLeadking, chemDisinfectReservoirTime, isChemDisinfectTempAboveTarget, ischemDisinfectWarmupTargetReached (should be isChemDisinfectWarmupTargetReached).

Add stateTrialCounter

Add stateTrialCounter

Add nelsonSupport, stateTrialCounter to header.

Add nelsonSupport, stateTrialCounter to header.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I simplified it. Now if fails, test ends. If passed ( < 3 errors), PASS result is set on exit with Complete state.

I simplified it. Now if fails, test ends. If passed ( < 3 errors), PASS result is set on exit with Complete state.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

I think I understand how this works now. Kind of confusing how this is done and strange to see passed set here when it just failed. If I understand correctly, test must fail 3 out of the 5 tests to...

I think I understand how this works now. Kind of confusing how this is done and strange to see passed set here when it just failed.
If I understand correctly, test must fail 3 out of the 5 tests to fail the whole test - otherwise it passes?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Value is overridden below if the test is repeated. If it is the last time through test, it needs to be set here as Pass/Fail based on Fail counter.

Value is overridden below if the test is repeated. If it is the last time through test, it needs to be set here as Pass/Fail based on Fail counter.

Removed.

Removed.

Moved declarations to top of file.

Moved declarations to top of file.

Moved to function header.

Moved to function header.

Fixed.

Fixed.

state is already in progress - no need to reassign it here. result is already in progress as well.

state is already in progress - no need to reassign it here.
result is already in progress as well.

Prefer not to have local statics. Move to top of file.

Prefer not to have local statics. Move to top of file.

Remove comment. Maybe move part about bumping to brief above.

Remove comment. Maybe move part about bumping to brief above.

Why are we passing test here? I think if you pass here, you will not return and retry. Should leave result as in progress to keep the test going.

Why are we passing test here? I think if you pass here, you will not return and retry. Should leave result as in progress to keep the test going.

Why is the L lower case?

Why is the L lower case?

HD-DEN-15272_FW Alarm 9 DG Fault Acc Vector Triggers ON Startup
HD-DEN-15272_FW Alarm 9 DG Fault Acc Vector Triggers ON Startup
DG-DEN-15660_Test Configuration Treatment Recovery
DG-DEN-15660_Test Configuration Treatment Recovery