fwcommon

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 07 Oct 2023
2:14 pm

Sean Nash

DEN-16446: Fixed function header comments.

Options
    • -2
    • +2
    /Utilities.c
1:32 pm

Dara Navaei

DEN-16446 updated the test support function

Options
    • -4
    • +0
    /TestSupport.c
Friday 06 Oct 2023
10:19 am

wbracken  (deleted user)

Should this have a set of parenthesis around the condition similar to line 437?

Should this have a set of parenthesis around the condition similar to line 437?

10:18 am

wbracken  (deleted user)

Resolved in code review.

Resolved in code review.

9:18 am

Dara Navaei

Merge branch 'staging' into develop

Options
    • -1
    • +1
    /NVDataMgmt.c
Tuesday 03 Oct 2023
2:33 pm

Dara Navaei

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

In the condition in line 437 we do a subtraction prior to comparing so there are extra parentheses in line 437.

Monday 02 Oct 2023
10:02 am

Dara Navaei

DEN-16446 updated the code for VectorCAST

Options
    • -9
    • +18
    /NVDataMgmt.c
Sunday 01 Oct 2023
4:15 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Saturday 30 Sep 2023
1:06 pm

Dara Navaei

Merge branch 'staging' into DEN-16446-dg-dev-test-clean-up

Options
1:05 pm

Dara Navaei

12:57 pm

Dara Navaei and jtaylor  (deleted user)

12:50 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    /NVDataMgmt.c
    • -2
    • +2
    /NVDataMgmt.h
12:29 pm

Sean Nash

Merged DEN-15792 to staging.

Options
11:45 am

Sean Nash

Merge branch 'DEN-15792-hd-software-design-description' into develop

Options
    • -5
    • +6
    /NVDataMgmt.c
11:34 am

Sean Nash

Merged staging to DEN-15792.

Options
Friday 29 Sep 2023
5:21 pm

Dara Navaei

DEN-16446 aded code comment

Options
    • -0
    • +1
    /Integrity.c
5:19 pm

Dara Navaei

DEN-16446 added code for VectorCAST tests only

Options
    • -4
    • +13
    /Integrity.c
11:16 am

jtaylor  (deleted user)

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

The question was resolved in comments for earlier default cases in this change. RESOLVED in CODE WALKTHROUGH.

11:14 am

jtaylor  (deleted user)

RESOLVED in CODE WALKTHROUGH. (with nausea)

RESOLVED in CODE WALKTHROUGH. (with nausea)

11:11 am

jtaylor  (deleted user)

But if VECTORCAST is defined there is no default clause. I'm suggesting: ... default: #ifndef VECTORCAST heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER; #endif break;

But if VECTORCAST is defined there is no default clause. I'm suggesting:
...
default:
#ifndef VECTORCAST
heatDisinfectUIState = HEAT_DISINFECT_UI_STATE_HEAT_UP_WATER;
#endif
break;

Thursday 28 Sep 2023
8:56 am

Dara Navaei

Done

Done

8:33 am

Dara Navaei

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

This code is the theoretical code for treatment recovery. At the moment this code is not reachable neither in the firmware or VectorCAST.

8:31 am

Dara Navaei

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp o...

This default is in an if statement to make sure we are less than NUM_OF_VALVES so the default cannot be reached in VectorCAST. But we keep the default in the code in case there was a memory stomp or other anomalies.

Wednesday 27 Sep 2023
4:40 pm

jtaylor  (deleted user)

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5). I would suggest using the ifdef within the body of the default clause, even ...

Our coding standard encourages always including default as the last clause, even if it is empty. (following misra 16.5).
I would suggest using the ifdef within the body of the default clause, even with the statement duplicated, or adding an else clause to the ifndef with a second, empty default.

1:07 pm

Sean Nash

What's left? When would this code ever become reachable?

What's left? When would this code ever become reachable?

8:30 am

jtaylor  (deleted user)

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

The default case should probably be present, whether or not VECTORCAST is defined. I suggest bringing the ifdef in, to eliminate only the "name =" line (479).

Sunday 24 Sep 2023
11:01 am

Sean Nash

DEN-15792: Comments update.

Options
    • -0
    • +2
    /NVDataMgmt.h
Saturday 23 Sep 2023
12:37 pm

Dara Navaei

DEN-16446 added more comments

Options
    • -0
    • +3
    /Integrity.c
Thursday 21 Sep 2023
10:57 am

Sean Nash

DEN-15792: Reverted last change re: set critical data function.

Options
    • -2
    • +1
    /Utilities.c
8:43 am

Dara Navaei

DEN-16446 updated the code for VectorCAST

Options
    • -0
    • +30
    /Integrity.c