fwcommon

Common.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Aug 2022
8:12 pm

Dara Navaei

DEN-12931 addressed the code review comments

Options
    • -1
    • +1
    /Common.h
8:10 pm

Dara Navaei

Removed the code.

Removed the code.

8:09 pm

Dara Navaei

Done.

Done.

8:08 pm

Dara Navaei

Done.

Done.

8:07 pm

Dara Navaei

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

I thought exiting the normal state is the last request we want to check after making sure nothing else is requested.

8:06 pm

Dara Navaei

Done.

Done.

8:03 pm

Dara Navaei

Blood leak is still in development. This will be addressed in DEN-13460.

Blood leak is still in development. This will be addressed in DEN-13460.

8:02 pm

Dara Navaei

Done.

Done.

7:59 pm

Dara Navaei

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.

We only do that if we do the == comparison. This is to make sure the compiler errors out if only one = is put instead of ==.

7:56 pm

Dara Navaei

Done.

Done.

7:55 pm

Dara Navaei

Done.

Done.

7:48 pm

Dara Navaei

This can be reached in VC since it is not in a for loop.

This can be reached in VC since it is not in a for loop.

7:48 pm

Dara Navaei

This can be reached in VC because it is not in a for loop.

This can be reached in VC because it is not in a for loop.

Friday 22 Jul 2022
8:28 am

Sean Nash

Why removed?

Why removed?

8:27 am

Sean Nash

Why removed? I thought we needed this for VC?

Why removed? I thought we needed this for VC?

Thursday 21 Jul 2022
9:03 pm

Sean Nash

F has been added.

F has been added.

9:01 pm

Sean Nash

No. Code removed.

No. Code removed.

8:58 pm

Sean Nash

If no actions handled in this mode, add a comment saying so.

If no actions handled in this mode, add a comment saying so.

8:52 pm

Sean Nash

Yes, at bottom of exec function above.

Yes, at bottom of exec function above.

8:50 pm

Sean Nash

Remove blank line.

Remove blank line.

8:49 pm

Sean Nash

Can we remove this now?

Can we remove this now?

10:30 am

Dara Navaei

DEN-13460 updated the code

Options
    • -0
    • +1
    /Common.h
  2. … 1 more file in changeset.
Monday 18 Jul 2022
4:14 pm

Dara Navaei

DEN-13460 updated the NV data

Options
    • -1
    • +2
    /Common.h
  2. … 2 more files in changeset.
2:49 pm

wbracken  (deleted user)

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

Check NEARLY_ZERO #define. Value should be 0.00000001F. I believe previous review commented indicated that all floating point #defines should have "F" at the end.

2:42 pm

wbracken  (deleted user)

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

SW_CONFIG_ENABLE_VALUE should be first in the conditional.

1:00 pm

wbracken  (deleted user)

Need #define for minimum vRef

Need #define for minimum vRef

12:55 pm

wbracken  (deleted user)

Is the data being published elsewhere?

Is the data being published elsewhere?

12:14 pm

wbracken  (deleted user)

Is this supposed to have been removed.

Is this supposed to have been removed.

Tuesday 12 Jul 2022
3:20 pm

Sean Nash

indent of cases looks too small.

indent of cases looks too small.

3:20 pm

Sean Nash

Looks like exit normal request (below) will take precedence over this request. Is that intended?

Looks like exit normal request (below) will take precedence over this request. Is that intended?