hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 19
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 18 Feb 2021
1:25 pm

Sean Nash

DEN-5887: ran local test script.

Options
    • -156
    • +5
    /results/Build_Status_Report.csv
    • -39331
    • +4815
    /results/VectorCAST.log
    • -48
    • +48
    /results/cppcheck.log
    • -16
    • +19
    /results/cppcheckError.csv
Wednesday 17 Feb 2021
5:13 pm

Sean Nash

DEN-6372: Added TODO.

Options
    • -0
    • +1
    /firmware/App/Modes/ModeTreatment.c
1:14 pm

Sean Nash

DEN-6372: Fixes per lab testing. Added function to AlarmMgmt to determine whether any alarms w/ stop property are active. Changed treatment mode handling of alarm stop from signal to modes approach to modes polling alarm mgmt approach. Added f/w support for override of treatment time remaining.

Options
    • -1
    • +1
    /firmware/App/Modes/Dialysis.c
    • -34
    • +62
    /firmware/App/Modes/ModeTreatment.c
    • -0
    • +2
    /firmware/App/Modes/ModeTreatment.h
    • -0
    • +13
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -20
    • +4
    /firmware/App/Services/SystemComm.c
    • -149
    • +29
    /firmware/App/Services/SystemCommMessages.c
    • -16
    • +4
    /firmware/App/Services/SystemCommMessages.h
11:07 am

Dara Navaei

DEN-6078 merged staging and resolved merge conflicts

Options
    • -15
    • +184
    /firmware/App/Modes/ModePreTreat.c
    • -37
    • +5
    /firmware/App/Modes/ModeTreatment.c
    • -4
    • +4
    /firmware/App/Services/SystemComm.c
    • -67
    • +93
    /firmware/App/Services/SystemCommMessages.c
11:02 am

Sean Nash

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

Stop signal is removed. But other alarm flags still exist so I added call to reset alarm signal flags as you suggested.

10:40 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:38 am

Dara Navaei

DEN-6078 commented the count to PWM conversion macros

Options
    • -2
    • +4
    /firmware/App/Controllers/Valves.c
10:38 am

qnguyen  (deleted user)

These new alarms have been added to the alarm table.

These new alarms have been added to the alarm table.

10:37 am

qnguyen  (deleted user)

These has been uncommented.

These has been uncommented.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:19 am

Sean Nash

Why commented out?

Why commented out?

9:18 am

Sean Nash

Need to add these new alarms to alarm table below.

Need to add these new alarms to alarm table below.

9:15 am

Sean Nash

Before switching to newly filled reservoir, we want to take a baseline weight (before starting UF with it). So we are initializing the starting and final weights for the reservoir here. As UF progr...

Before switching to newly filled reservoir, we want to take a baseline weight (before starting UF with it). So we are initializing the starting and final weights for the reservoir here. As UF progresses on this reservoir after we switch to it, the final weight will gradually increase and the delta between the two is how much UF we've taken using this reservoir.

Tuesday 16 Feb 2021
1:20 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

1:19 pm

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:00 pm

Sean Nash

DEN-6372: Addressed code review feedback.

Options
    • -1
    • +1
    /firmware/App/Modes/Rinseback.c
    • -10
    • +8
    /firmware/App/Services/PIControllers.c
11:58 am

Sean Nash

Is that a rule in our coding standard?

Is that a rule in our coding standard?

11:22 am

Sean Nash

Fixed.

Fixed.

11:21 am

Sean Nash

Fixed.

Fixed.

11:17 am

Sean Nash

Done.

Done.

11:13 am

qnguyen  (deleted user)

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

It looks like the alarm stop signal flag is reset in another function? resetAlarmSignalFlags function.

11:04 am

qnguyen  (deleted user)

Right after the if statement ends.

Right after the if statement ends.