hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 10 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Mar 2021
9:41 am

Sean Nash

DEN-6372: Addressed code review feedback.

Options
    • -12
    • +13
    /firmware/App/Modes/ModeTreatment.c
    • -22
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
8:53 am

qnguyen  (deleted user)

This file is generated by halcogen and should not be modified.

This file is generated by halcogen and should not be modified.

Sunday 28 Feb 2021
10:43 pm

Sean Nash

RTCs are sync'd by UI sending its date/time to HD and DG f/w. However, RTC time is not used for treatment time. Treatment time is accumulated using HD timer counter. HD then uses this and set treat...

RTCs are sync'd by UI sending its date/time to HD and DG f/w.
However, RTC time is not used for treatment time. Treatment time is accumulated using HD timer counter. HD then uses this and set treatment duration to calculate time remaining. All are then sent to UI regularly.

10:39 pm

Sean Nash

Done.

Done.

10:22 pm

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

5:12 pm

qnguyen  (deleted user)

5:12 pm

qnguyen  (deleted user)

Removed. It was leftover when battery exec function was called from general task.

Removed. It was leftover when battery exec function was called from general task.

5:11 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Removed unused include

Options
    • -1
    • +0
    /firmware/App/Tasks/TaskGeneral.c
5:10 pm

qnguyen  (deleted user)

No one is using this flag. This flag gets set to TRUE previously when the HD starts to command DG to sample water. The DG sample water command consists of start, stop, end sample water. So this fla...

No one is using this flag. This flag gets set to TRUE previously when the HD starts to command DG to sample water.
The DG sample water command consists of start, stop, end sample water. So this flag does not make sense anymore.

4:23 pm

Sean Nash

Why added?

Why added?

4:21 pm

Sean Nash

Where does this get set to TRUE? Who uses this flag?

Where does this get set to TRUE? Who uses this flag?

2:50 am

qnguyen  (deleted user)

Aligned.

Aligned.

Saturday 27 Feb 2021
5:09 pm

pmontazemi  (deleted user)

4:48 pm

pmontazemi  (deleted user)

1. How are we syncing times between UI RTC and HD RTC? 2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI...

1. How are we syncing times between UI RTC and HD RTC?
2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI APP?

4:37 pm

pmontazemi  (deleted user)

Align comment.

Align comment.

12:05 am

qnguyen  (deleted user)

Consider using TREATMENT_STATE_DATA_T data structure.

Consider using TREATMENT_STATE_DATA_T data structure.

Friday 26 Feb 2021
1:53 pm

Sean Nash

DEN-6372: UF control change.

Options
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
11:23 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added timeout to i2c transmit wait

Options
    • -8
    • +30
    /firmware/App/Drivers/Battery.c
9:05 am

Sean Nash

DEN-6372: Fixed bug in user signal handling.

Options
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
Thursday 25 Feb 2021
1:56 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Moved pre-treatment recirc states to common

Options
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -29
    • +30
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -0
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.h
Wednesday 24 Feb 2021
11:32 pm

Sean Nash

DEN-6372: Fixes to final rinseback.

Options
    • -4
    • +17
    /firmware/App/Modes/ModeTreatment.c
    • -0
    • +1
    /firmware/App/Modes/ModeTreatment.h
    • -12
    • +20
    /firmware/App/Modes/Rinseback.c
10:37 pm

Sean Nash

DEN-6372: Fixes to end treatment and final rinseback.

Options
    • -9
    • +10
    /firmware/App/Modes/ModeTreatment.c
    • -2
    • +2
    /firmware/App/Modes/Rinseback.c
    • -0
    • +2
    /firmware/App/Modes/TreatmentEnd.c
9:57 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added DG restart and lost comm check

Options
    • -0
    • +20
    /firmware/App/Controllers/DGInterface.c
    • -0
    • +2
    /firmware/App/Controllers/DGInterface.h
    • -1
    • +7
    /firmware/App/Services/SystemComm.c
    • -0
    • +3
    /firmware/App/Tasks/TaskGeneral.c
6:25 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Moved self-tests states to common and updated message ids

Options
    • -35
    • +0
    /firmware/App/Modes/SelfTests.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.c
    • -2
    • +2
    /firmware/App/Services/SystemCommMessages.h
6:25 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Battery test

Options
    • -0
    • +124
    /firmware/App/Drivers/Battery.c
    • -0
    • +40
    /firmware/App/Drivers/Battery.h
    • -4
    • +8
    /firmware/App/Tasks/TaskBG.c
    • -1
    • +2
    /firmware/App/Tasks/TaskGeneral.c
    • -12
    • +12
    /firmware/HD.dil
    • -2
    • +4
    /firmware/HD.hcg
    • -0
    • +38
    /firmware/include/i2c.h
    • -0
    • +849
    /firmware/source/i2c.c
    • -0
    • +11
    /firmware/source/notification.c
    • -1
    • +1
    /firmware/source/pinmux.c
    • -0
    • +4
    /firmware/source/sys_main.c
4:16 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Polling alarm stop status

Options
    • -25
    • +18
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -17
    • +1
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -1
    • +0
    /firmware/App/Modes/PreTreatmentRecirc.h
    • -25
    • +2
    /firmware/App/Modes/Prime.c
    • -1
    • +0
    /firmware/App/Modes/Prime.h
    • -23
    • +5
    /firmware/App/Modes/SelfTests.c
    • -0
    • +13
    /firmware/App/Services/AlarmMgmt.c
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
12:54 pm

qnguyen  (deleted user)

HD-DEN-7091_Pre Treatment Mode
HD-DEN-7091_Pre Treatment Mode
Tuesday 23 Feb 2021
5:16 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Combined sample water result state

Options
    • -31
    • +6
    /firmware/App/Modes/SampleWater.c
4:33 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added UI patient connection confirm handler

Options
    • -23
    • +100
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +3
    /firmware/App/Modes/ModePreTreat.h
    • -4
    • +3
    /firmware/App/Modes/SampleWater.c
    • -1
    • +1
    /firmware/App/Modes/SampleWater.h
    • -0
    • +8
    /firmware/App/Services/SystemComm.c
    • -18
    • +62
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +6
    /firmware/App/Services/SystemCommMessages.h
3:22 pm

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added UI continue to treatment user request handler

Options
    • -0
    • +1
    /firmware/App/HDCommon.h
    • -3
    • +52
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -13
    • +0
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -1
    • +0
    /firmware/App/Modes/PreTreatmentRecirc.h
    • -1
    • +1
    /firmware/App/Modes/SelfTests.c
    • -1
    • +30
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +6
    /firmware/App/Services/SystemCommMessages.h