hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 09 Mar 2021
1:29 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -2
    • +2
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +8
    /firmware/App/Services/SystemComm.c
1:22 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:21 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -4
    • +3
    /firmware/App/Controllers/FluidLeak.c
1:19 pm

Sean Nash

Also mention return value in @return of header.

Also mention return value in @return of header.

1:17 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:16 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Controllers/FluidLeak.c
    • -3
    • +3
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
1:16 pm

Sean Nash

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

1:14 pm

Sean Nash

I expected to see a couple new cases here for handling override commands.

I expected to see a couple new cases here for handling override commands.

1:11 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -2
    • +1
    /firmware/App/Services/FPGA.c
1:10 pm

Sean Nash

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

1:10 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:07 pm

Sean Nash

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

1:04 pm

Sean Nash

Consider merging these two declarations.

Consider merging these two declarations.

12:13 pm

pmontazemi  (deleted user)

HD-DEN-6890_Fluid Leak Detector Driver
HD-DEN-6890_Fluid Leak Detector Driver
12:11 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.c
    • -19
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -36
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -9
    • +5
    /firmware/App/Modes/ModeTreatment.c
    • -20
    • +0
    /firmware/App/Services/SystemComm.c
    • -41
    • +1
    /firmware/App/Services/SystemCommMessages.c
11:52 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -11
    • +13
    /firmware/App/Controllers/FluidLeak.c
    • -2
    • +2
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
    • -3
    • +68
    /firmware/App/Services/SystemCommMessages.c
10:58 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +10
    /firmware/App/Services/SystemCommMessages.h
10:44 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -339
    • +74
    /firmware/App/Controllers/FluidLeak.c
    • -5
    • +4
    /firmware/App/Controllers/FluidLeak.h
    • -3
    • +32
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +2
    /firmware/source/sys_main.c
9:09 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Initial commit

Options
    • -0
    • +519
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +57
    /firmware/App/Controllers/FluidLeak.h
    • -2
    • +20
    /firmware/App/Services/FPGA.c
    • -0
    • +2
    /firmware/App/Services/FPGA.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.c
Saturday 06 Mar 2021
3:11 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Fixed header define

Options
    • -1
    • +1
    /firmware/App/Modes/ConsumableSelfTest.h
2:39 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Moved reservoir management into pre-treatment module

Options
    • -1
    • +269
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +4
    /firmware/App/Modes/ModePreTreat.h
    • -139
    • +2
    /firmware/App/Modes/Prime.c
    • -0
    • +2
    /firmware/App/Modes/Prime.h
2:18 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added consumable self-test sub-mode

Options
    • -0
    • +160
    /firmware/App/Modes/ConsumableSelfTest.c
    • -0
    • +47
    /firmware/App/Modes/ConsumableSelfTest.h
    • -4
    • +35
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +1
    /firmware/App/Modes/ModePreTreat.h
    • -1
    • +1
    /firmware/App/Modes/SelfTests.c
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -3
    • +22
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
Friday 05 Mar 2021
4:19 pm

Sean Nash

DEN-7117: Added implementation to syringe pump driver. Fixed saline bolus response msg. Fixed UF ranges given to UI.

Options
    • -58
    • +237
    /firmware/App/Controllers/SyringePump.c
    • -2
    • +17
    /firmware/App/Modes/Dialysis.c
    • -0
    • +1
    /firmware/App/Modes/Dialysis.h
    • -3
    • +3
    /firmware/App/Modes/ModeTreatment.c
    • -1
    • +4
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.h
    • -1
    • +5
    /firmware/App/Tasks/TaskPriority.c
    • -0
    • +2
    /firmware/source/sys_main.c
Thursday 04 Mar 2021
9:33 pm

Sean Nash

DEN-7117: Added new syringe pump module. Added FPGA module functions for syringe pump. Added broadcast function for syringe pump data msg.

Options
    • -3
    • +3
    /firmware/App/Controllers/PresOccl.c
    • -0
    • +763
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +68
    /firmware/App/Controllers/SyringePump.h
    • -11
    • +82
    /firmware/App/Services/FPGA.c
    • -0
    • +14
    /firmware/App/Services/FPGA.h
    • -0
    • +28
    /firmware/App/Services/SystemCommMessages.c
    • -1
    • +5
    /firmware/App/Services/SystemCommMessages.h
10:47 am

Sean Nash

10:45 am

Dara Navaei , pmontazemi  (deleted user) and qnguyen  (deleted user)

10:27 am

Sean Nash

DEN-6372: Merge from staging pt 2.

Options
    • -27
    • +15
    /firmware/App/Controllers/BloodFlow.c
    • -21
    • +66
    /firmware/App/Controllers/DGInterface.c
    • -3
    • +4
    /firmware/App/Controllers/DGInterface.h
    • -24
    • +7
    /firmware/App/Controllers/DialInFlow.c
    • -13
    • +92
    /firmware/App/Controllers/PresOccl.c
    • -2
    • +3
    /firmware/App/Controllers/PresOccl.h
    • -5
    • +17
    /firmware/App/Controllers/Valves.c
    • -1
    • +3
    /firmware/App/HDCommon.h
    • -9
    • +6
    /firmware/App/Modes/Dialysis.c
    • -1
    • +2
    /firmware/App/Modes/Dialysis.h
    • -118
    • +117
    /firmware/App/Modes/ModePreTreat.c
    • -0
    • +230
    /firmware/App/Modes/PreTreatmentRecirc.c
    • -0
    • +1252
    /firmware/App/Modes/SelfTests.c
    • -0
    • +7
    /firmware/App/Services/AlarmMgmt.h
    • -2
    • +33
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +3
    /firmware/App/Services/SystemCommMessages.h
10:13 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Combined self-tests states and removed current min check when pumps running

Options
    • -2
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +1
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +1
    /firmware/App/Controllers/DialOutFlow.c
    • -29
    • +36
    /firmware/App/Modes/SelfTests.c
9:34 am

Sean Nash

HD-DEN-6372_HD Rinseback
HD-DEN-6372_HD Rinseback
Wednesday 03 Mar 2021
4:35 pm

Sean Nash

DEN-6372: merged from staging.

Options
    • -4
    • +5
    /firmware/App/Controllers/BloodFlow.c
    • -31
    • +74
    /firmware/App/Controllers/DGInterface.c
    • -1
    • +11
    /firmware/App/Controllers/DGInterface.h
    • -4
    • +5
    /firmware/App/Controllers/DialInFlow.c
    • -1
    • +1
    /firmware/App/Controllers/DialOutFlow.c
    • -12
    • +42
    /firmware/App/Controllers/PresOccl.c
    • -5
    • +19
    /firmware/App/Modes/Dialysis.c
    • -11
    • +176
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +1
    /firmware/App/Modes/ModeTreatment.c
    • -0
    • +1
    /firmware/App/Modes/ModeTreatment.h
    • -0
    • +1
    /firmware/App/Services/AlarmMgmt.h
    • -0
    • +4
    /firmware/App/Services/SystemComm.c
    • -46
    • +97
    /firmware/App/Services/SystemCommMessages.c
    • -5
    • +15
    /firmware/App/Services/SystemCommMessages.h