hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 10 Mar 2021
10:17 am

Sean Nash

DEN-7117: Updated ramping profile.

Options
    • -14
    • +36
    /firmware/App/Controllers/SyringePump.c
10:11 am

Quang Nguyen <qnguyen@diality.com>

DEN-7091: Added build switches to skip self-tests

Options
    • -0
    • +2
    /firmware/App/Controllers/BloodFlow.c
    • -2
    • +9
    /firmware/App/Controllers/DGInterface.c
    • -0
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +4
    /firmware/App/HDCommon.h
    • -2
    • +19
    /firmware/App/Modes/ConsumableSelfTest.c
    • -16
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -1
    • +0
    /firmware/App/Modes/ModePreTreat.h
    • -5
    • +1
    /firmware/App/Modes/SelfTests.c
Tuesday 09 Mar 2021
4:56 pm

Sean Nash

Did you add a call to this function in PriorityTask.c?

Did you add a call to this function in PriorityTask.c?

4:55 pm

Sean Nash

I don't think you need ModeTreatmentParams.h or OperationModes.h.

I don't think you need ModeTreatmentParams.h or OperationModes.h.

4:43 pm

Sean Nash

DEN-7117: Continued implementation of syringe pump controller.

Options
    • -1
    • +1
    /firmware/App/Controllers/PresOccl.c
    • -101
    • +430
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +3
    /firmware/App/Controllers/SyringePump.h
    • -4
    • +4
    /firmware/App/Services/SystemCommMessages.c
3:11 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Services/FPGA.c
    • -10
    • +10
    /firmware/App/Services/SystemCommMessages.c
1:34 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:34 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -3
    • +3
    /firmware/App/Services/FPGA.c
1:31 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:30 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.c
1:30 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:29 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -2
    • +2
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +8
    /firmware/App/Services/SystemComm.c
1:22 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:21 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -4
    • +3
    /firmware/App/Controllers/FluidLeak.c
1:19 pm

Sean Nash

Also mention return value in @return of header.

Also mention return value in @return of header.

1:17 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:16 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Controllers/FluidLeak.c
    • -3
    • +3
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
1:16 pm

Sean Nash

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

1:14 pm

Sean Nash

I expected to see a couple new cases here for handling override commands.

I expected to see a couple new cases here for handling override commands.

1:11 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -2
    • +1
    /firmware/App/Services/FPGA.c
1:10 pm

Sean Nash

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

1:10 pm

pmontazemi  (deleted user)

Addressed.

Addressed.

1:07 pm

Sean Nash

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

1:04 pm

Sean Nash

Consider merging these two declarations.

Consider merging these two declarations.

12:13 pm

pmontazemi  (deleted user)

HD-DEN-6890_Fluid Leak Detector Driver
HD-DEN-6890_Fluid Leak Detector Driver
12:11 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Controllers/DGInterface.c
    • -19
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -36
    • +1
    /firmware/App/Modes/ModePreTreat.c
    • -9
    • +5
    /firmware/App/Modes/ModeTreatment.c
    • -20
    • +0
    /firmware/App/Services/SystemComm.c
    • -41
    • +1
    /firmware/App/Services/SystemCommMessages.c
11:52 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -11
    • +13
    /firmware/App/Controllers/FluidLeak.c
    • -2
    • +2
    /firmware/App/Services/FPGA.c
    • -1
    • +1
    /firmware/App/Services/FPGA.h
    • -3
    • +68
    /firmware/App/Services/SystemCommMessages.c
10:58 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -1
    • +1
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +10
    /firmware/App/Services/SystemCommMessages.h
10:44 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Options
    • -339
    • +74
    /firmware/App/Controllers/FluidLeak.c
    • -5
    • +4
    /firmware/App/Controllers/FluidLeak.h
    • -3
    • +32
    /firmware/App/Services/SystemCommMessages.c
    • -0
    • +2
    /firmware/source/sys_main.c
9:09 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Initial commit

Options
    • -0
    • +519
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +57
    /firmware/App/Controllers/FluidLeak.h
    • -2
    • +20
    /firmware/App/Services/FPGA.c
    • -0
    • +2
    /firmware/App/Services/FPGA.h
    • -4
    • +0
    /firmware/App/Services/SystemComm.c
    • -1
    • +0
    /firmware/App/Services/SystemCommMessages.c