hdfirmware

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DEN-7117: Updated ramping profile.

    • -14
    • +36
    /firmware/App/Controllers/SyringePump.c
DEN-7091: Added build switches to skip self-tests

    • -2
    • +9
    /firmware/App/Controllers/DGInterface.c
    • -0
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +19
    /firmware/App/Modes/ConsumableSelfTest.c
Did you add a call to this function in PriorityTask.c?

Did you add a call to this function in PriorityTask.c?

I don't think you need ModeTreatmentParams.h or OperationModes.h.

I don't think you need ModeTreatmentParams.h or OperationModes.h.

DEN-7117: Continued implementation of syringe pump controller.

    • -101
    • +430
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +3
    /firmware/App/Controllers/SyringePump.h
DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Also mention return value in @return of header.

Also mention return value in @return of header.

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

I expected to see a couple new cases here for handling override commands.

I expected to see a couple new cases here for handling override commands.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

Addressed.

Addressed.

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Returns TRUE if dry, FALSE if wet. Consider renaming function in a way that makes sense for this return value (e.g. noFluidLeakDetected).

Consider merging these two declarations.

Consider merging these two declarations.

HD-DEN-6890_Fluid Leak Detector Driver
HD-DEN-6890_Fluid Leak Detector Driver
DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

    • -1
    • +1
    /firmware/App/Controllers/DGInterface.c
    • -19
    • +1
    /firmware/App/Controllers/DGInterface.h
    • -20
    • +0
    /firmware/App/Services/SystemComm.c
DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

    • -11
    • +13
    /firmware/App/Controllers/FluidLeak.c
DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

    • -339
    • +74
    /firmware/App/Controllers/FluidLeak.c
DEN-6890: Initial commit

    • -0
    • +519
    /firmware/App/Controllers/FluidLeak.c
    • -0
    • +57
    /firmware/App/Controllers/FluidLeak.h