hdfirmware

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Addressed code review comments

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

No, we do not.

No, we do not.

Addressed.

Addressed.

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

Do we need different states if the purpose is to trigger an alarm?

Do we need different states if the purpose is to trigger an alarm?

Includes should be in alphabet order for organize purpose.

Includes should be in alphabet order for organize purpose.

DEN-6890: Addressed code review comments

Added.

Added.

Removed.

Removed.

DEN-7117: Phase out UF off state.

DEN-7117: update to ramping.

    • -49
    • +43
    /firmware/App/Controllers/SyringePump.c
DEN-7117: Updated ramping profile.

    • -14
    • +36
    /firmware/App/Controllers/SyringePump.c
DEN-7091: Added build switches to skip self-tests

    • -2
    • +9
    /firmware/App/Controllers/DGInterface.c
    • -0
    • +2
    /firmware/App/Controllers/DialInFlow.c
    • -2
    • +19
    /firmware/App/Modes/ConsumableSelfTest.c
Did you add a call to this function in PriorityTask.c?

Did you add a call to this function in PriorityTask.c?

I don't think you need ModeTreatmentParams.h or OperationModes.h.

I don't think you need ModeTreatmentParams.h or OperationModes.h.

DEN-7117: Continued implementation of syringe pump controller.

    • -101
    • +430
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +3
    /firmware/App/Controllers/SyringePump.h
DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

Also mention return value in @return of header.

Also mention return value in @return of header.

Addressed.

Addressed.

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver