Activity hdfirmware/

10:25 am

Peman Montazemi <pmontazemi@diality.com>

More
014854f
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-DEN-6890-1

DEN-6890: Addressed code review comments

- -0
- +4
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c

9:54 am

Sean Nash

More
Re: HD-DEN-6890-1
replied to pmontazemi (deleted user)

I think you should call clearAlarmCondition() when you sense DRY state.

9:46 am

Sean Nash

More
HD-DEN-5887-1
Closed

9:29 am

Peman Montazemi <pmontazemi@diality.com>

More
ee4aba5
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-DEN-6890-1 HD-DEN-7117-1

Addressed code review comments

- -1
- +1
/firmware/source/sys_main.c
- History
- Source
- Diff
/firmware/source/sys_main.c

9:28 am

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to qnguyen (deleted user)

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

9:28 am

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to qnguyen (deleted user)

No, we do not.

9:27 am

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to qnguyen (deleted user)

Addressed.

6:13 pm

qnguyen (deleted user)

More
Re: HD-DEN-6890-1
commented on review

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

6:11 pm

qnguyen (deleted user)

More
Re: HD-DEN-6890-1
commented on review

Do we need different states if the purpose is to trigger an alarm?

5:42 pm

qnguyen (deleted user)

More
Re: HD-DEN-6890-1
commented on review

Includes should be in alphabet order for organize purpose.

2:06 pm

pmontazemi (deleted user)

More
HD-DEN-6890-1
added Dara Navaei and qnguyen (deleted user)

2:00 pm

Peman Montazemi <pmontazemi@diality.com>

More
d2c7420
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-DEN-6890-1 HD-DEN-5980-1 HD-DEN-7117-1

DEN-6890: Addressed code review comments

- -3
- +1
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c
- -1
- +5
/firmware/App/Tasks/TaskPriority.c
- History
- Source
- Diff
/firmware/App/Tasks/TaskPriority.c

1:56 pm

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to Sean Nash

Added.

1:51 pm

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to Sean Nash

Removed.

11:37 am

Sean Nash

More
606c80d
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-UCOMMITS-19

DEN-7117: Phase out UF off state.

- -29
- +4
/firmware/App/Modes/Dialysis.c
- History
- Source
- Diff
/firmware/App/Modes/Dialysis.c

11:08 am

Sean Nash

More
893bdb4
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-UCOMMITS-19

DEN-7117: update to ramping.

- -49
- +43
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

10:17 am

Sean Nash

More
cda8fe9
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-UCOMMITS-19

DEN-7117: Updated ramping profile.

- -14
- +36
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c

10:11 am

Quang Nguyen <qnguyen@diality.com>

More
9e2667a
changed 8 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 360 more HD-DEN-7091-1

DEN-7091: Added build switches to skip self-tests

- -0
- +2
/firmware/App/Controllers/BloodFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/BloodFlow.c
- -2
- +9
/firmware/App/Controllers/DGInterface.c
- History
- Source
- Diff
/firmware/App/Controllers/DGInterface.c
- -0
- +2
/firmware/App/Controllers/DialInFlow.c
- History
- Source
- Diff
/firmware/App/Controllers/DialInFlow.c
- -2
- +4
/firmware/App/HDCommon.h
- History
- Source
- Diff
/firmware/App/HDCommon.h
- -2
- +19
/firmware/App/Modes/ConsumableSelfTest.c
- History
- Source
- Diff
/firmware/App/Modes/ConsumableSelfTest.c
- -16
- +1
/firmware/App/Modes/ModePreTreat.c
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.c
- -1
- +0
/firmware/App/Modes/ModePreTreat.h
- History
- Source
- Diff
/firmware/App/Modes/ModePreTreat.h
- -5
- +1
/firmware/App/Modes/SelfTests.c
- History
- Source
- Diff
/firmware/App/Modes/SelfTests.c

4:56 pm

Sean Nash

More
Re: HD-DEN-6890-1
commented on review

Did you add a call to this function in PriorityTask.c?

4:55 pm

Sean Nash

More
Re: HD-DEN-6890-1
commented on review

I don't think you need ModeTreatmentParams.h or OperationModes.h.

4:43 pm

Sean Nash

More
acb165d
changed 4 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 361 more HD-DEN-7117-1

DEN-7117: Continued implementation of syringe pump controller.

- -1
- +1
/firmware/App/Controllers/PresOccl.c
- History
- Source
- Diff
/firmware/App/Controllers/PresOccl.c
- -101
- +430
/firmware/App/Controllers/SyringePump.c
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.c
- -0
- +3
/firmware/App/Controllers/SyringePump.h
- History
- Source
- Diff
/firmware/App/Controllers/SyringePump.h
- -4
- +4
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

3:11 pm

Peman Montazemi <pmontazemi@diality.com>

More
7862d0e
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-DEN-6890-1

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

- -1
- +1
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c
- -10
- +10
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

1:34 pm

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to Sean Nash

Addressed.

1:34 pm

Peman Montazemi <pmontazemi@diality.com>

More
e36779b
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-UCOMMITS-19

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

- -3
- +3
/firmware/App/Services/FPGA.c
- History
- Source
- Diff
/firmware/App/Services/FPGA.c

1:31 pm

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to Sean Nash

Addressed.

1:30 pm

Peman Montazemi <pmontazemi@diality.com>

More
1c71ed3
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-UCOMMITS-20

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

- -1
- +0
/firmware/App/Services/SystemCommMessages.c
- History
- Source
- Diff
/firmware/App/.../SystemCommMessages.c

1:30 pm

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to Sean Nash

Addressed.

1:29 pm

Peman Montazemi <pmontazemi@diality.com>

More
1761ea6
changed 2 files
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-DEN-6890-1

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

- -2
- +2
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c
- -0
- +8
/firmware/App/Services/SystemComm.c
- History
- Source
- Diff
/firmware/App/Services/SystemComm.c

1:22 pm

pmontazemi (deleted user)

More
Re: HD-DEN-6890-1
replied to Sean Nash

Addressed.

1:21 pm

Peman Montazemi <pmontazemi@diality.com>

More
28cf92e
changed 1 file
DEN-10153_Treatment_Log_Prescribed_UF, DEN-10155-treatment-end-paused-state-not-displaying-resume-option and 363 more HD-UCOMMITS-19

DEN-6890: Implemented first pass of HD Fluid Leak Detector driver

- -4
- +3
/firmware/App/Controllers/FluidLeak.c
- History
- Source
- Diff
/firmware/App/Controllers/FluidLeak.c

hdfirmware

Stats

Commits this week: 0

Commit Activity

52 week commits volume

Commits by day

Commits by hour

Commit calendar

Most active committers (90 days)

Peman Montazemi <pmontazemi@diality.com>

Sean Nash

Sean Nash

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

pmontazemi (deleted user)

pmontazemi (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

qnguyen (deleted user)

pmontazemi (deleted user)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

pmontazemi (deleted user)

Sean Nash

Sean Nash

Sean Nash

Quang Nguyen <qnguyen@diality.com>

Sean Nash

Sean Nash

Sean Nash

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

Peman Montazemi <pmontazemi@diality.com>

pmontazemi (deleted user)

Peman Montazemi <pmontazemi@diality.com>