hdfirmware

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit: 19 Nov 25
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Mar 2021
10:49 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Resolved merge conflicts from staging

Options
    • -3
    • +102
    /firmware/App/Services/FPGA.c
    • -0
    • +10
    /firmware/App/Services/FPGA.h
    • -4
    • +23
    /firmware/App/Services/SystemComm.c
    • -170
    • +373
    /firmware/App/Services/SystemCommMessages.c
    • -22
    • +45
    /firmware/App/Services/SystemCommMessages.h
10:08 am

Sean Nash

DEN-7117: Fixed error in safety volume checks.

Options
    • -7
    • +15
    /firmware/App/Controllers/BloodFlow.c
    • -3
    • +65
    /firmware/App/Controllers/SyringePump.c
    • -0
    • +23
    /firmware/App/Controllers/SyringePump.h
    • -1
    • +1
    /firmware/App/Modes/Dialysis.c
    • -5
    • +5
    /firmware/App/Modes/ModeInitPOST.c
Thursday 11 Mar 2021
4:51 pm

Peman Montazemi <pmontazemi@diality.com>

Added missing OperationModes.h to reduce CCS warning list by 1

Options
    • -0
    • +1
    /firmware/App/Controllers/FluidLeak.c
4:29 pm

Peman Montazemi <pmontazemi@diality.com>

Added check fluid leak detector state outside of INIT_MODE

Options
    • -16
    • +19
    /firmware/App/Controllers/FluidLeak.c
2:50 pm

Sean Nash

DEN-7117: Updated safety volume logic for saline bolus, blood prime, and rinseback. Removed concept of a UF complete state.

Options
    • -2
    • +1
    /firmware/App/Controllers/BloodFlow.c
    • -0
    • +1
    /firmware/App/Controllers/BloodFlow.h
    • -4
    • +1
    /firmware/App/Modes/BloodPrime.c
    • -6
    • +3
    /firmware/App/Modes/Dialysis.c
    • -5
    • +5
    /firmware/App/Modes/ModeInitPOST.c
    • -4
    • +1
    /firmware/App/Modes/Rinseback.c
12:26 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -0
    • +2
    /firmware/App/Controllers/FluidLeak.h
10:38 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:26 am

pmontazemi  (deleted user)

Addressed.

Addressed.

10:25 am

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -0
    • +4
    /firmware/App/Controllers/FluidLeak.c
9:54 am

Sean Nash

I think you should call clearAlarmCondition() when you sense DRY state.

I think you should call clearAlarmCondition() when you sense DRY state.

9:46 am

Sean Nash

9:29 am

Peman Montazemi <pmontazemi@diality.com>

Addressed code review comments

Options
    • -1
    • +1
    /firmware/source/sys_main.c
9:28 am

pmontazemi  (deleted user)

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

It is recoverable. As soon as the fluid leak is cleared, this alarm will self-remove. This is a simple ON/OFF implementation because we have 0 tolerance for leaks.

9:28 am

pmontazemi  (deleted user)

No, we do not.

No, we do not.

9:27 am

pmontazemi  (deleted user)

Addressed.

Addressed.

Wednesday 10 Mar 2021
6:13 pm

qnguyen  (deleted user)

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

Is this alarm recoverable? If yes, should we clear this alarm once no fluid leak is detected?

6:11 pm

qnguyen  (deleted user)

Do we need different states if the purpose is to trigger an alarm?

Do we need different states if the purpose is to trigger an alarm?

5:42 pm

qnguyen  (deleted user)

Includes should be in alphabet order for organize purpose.

Includes should be in alphabet order for organize purpose.

2:06 pm

pmontazemi  (deleted user)

2:00 pm

Peman Montazemi <pmontazemi@diality.com>

DEN-6890: Addressed code review comments

Options
    • -3
    • +1
    /firmware/App/Controllers/FluidLeak.c
    • -1
    • +5
    /firmware/App/Tasks/TaskPriority.c
1:56 pm

pmontazemi  (deleted user)

Added.

Added.